diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-10-11 19:28:08 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-11 19:28:08 +0000 |
| commit | bfc5f6011dd402a1fc07a522c3f25ab405f3e3ea (patch) | |
| tree | 9ab3891f72cc881ec6845b36a33a797d52f0f0bb | |
| parent | 7ade11c1cdc8ea1bf065c6b7d4c358d38026e2a7 (diff) | |
| download | pdfium-bfc5f6011dd402a1fc07a522c3f25ab405f3e3ea.tar.xz | |
Add check_targets list to .gn.
Start trying to pass "gn check".
Change-Id: Iec694d8abf558f3e1ca477dd3934020088e43cb5
Reviewed-on: https://pdfium-review.googlesource.com/c/43895
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
| -rw-r--r-- | .gn | 13 | ||||
| -rw-r--r-- | samples/BUILD.gn | 6 |
2 files changed, 17 insertions, 2 deletions
@@ -15,3 +15,16 @@ default_args = { # PDFium does not want to switch to C++14 yet. use_cxx11 = true } + +check_targets = [ + "//samples/*", + + # TODO(thestig): Work on these. + #"//core/*", # Need to split off. + #"//fpdfsdk/*", # Need to split off. + #"//fxbarcode/*", # Need to split off. + #"//fxjs/*", # Need to split off. + #"//testing/*", + #"//testing/fuzzers/*", + #"//xfa/*", # Need to split off. +] diff --git a/samples/BUILD.gn b/samples/BUILD.gn index 30cc8ef6e9..909de2eae0 100644 --- a/samples/BUILD.gn +++ b/samples/BUILD.gn @@ -58,10 +58,12 @@ executable("pdfium_test") { configs += [ ":pdfium_samples_config" ] if (pdf_enable_v8) { - deps += [ "//v8:v8_libplatform" ] + deps += [ + "//v8:v8_headers", + "//v8:v8_libplatform", + ] include_dirs = [ "//v8", - "//v8/include", ] configs += [ "//v8:external_startup_data" ] } |