diff options
| author | Wei Li <weili@chromium.org> | 2016-05-04 21:13:15 -0700 |
|---|---|---|
| committer | Wei Li <weili@chromium.org> | 2016-05-04 21:13:15 -0700 |
| commit | 5fe7ae721a2e843007de69fcf76c252da942440f (patch) | |
| tree | f4609e975904f48d5b4b28677d3ac6026425df3c | |
| parent | 6e1ae8614e7c81d8e6a6249ee73cfbf8abb0d099 (diff) | |
| download | pdfium-5fe7ae721a2e843007de69fcf76c252da942440f.tar.xz | |
Properly fix the warnings
ASSERT(statement) will not execute statement in release builds. So
need to move statements outside ASSERT().
TBR=tsepez@chromium.org,dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1949613004 .
| -rw-r--r-- | xfa/fxfa/parser/xfa_object_imp.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp index 32da7f7a17..91497a50d0 100644 --- a/xfa/fxfa/parser/xfa_object_imp.cpp +++ b/xfa/fxfa/parser/xfa_object_imp.cpp @@ -4574,7 +4574,8 @@ CXFA_Node* CXFA_Node::GetChild(int32_t index, int32_t CXFA_Node::InsertChild(int32_t index, CXFA_Node* pNode) { ASSERT(!pNode->m_pNext); pNode->m_pParent = this; - ASSERT(m_pDocument->RemovePurgeNode(pNode)); + FX_BOOL ret = m_pDocument->RemovePurgeNode(pNode); + ASSERT(ret); if (m_pChild == NULL || index == 0) { if (index > 0) { @@ -4622,7 +4623,8 @@ FX_BOOL CXFA_Node::InsertChild(CXFA_Node* pNode, CXFA_Node* pBeforeNode) { ASSERT(false); return FALSE; } - ASSERT(m_pDocument->RemovePurgeNode(pNode)); + FX_BOOL ret = m_pDocument->RemovePurgeNode(pNode); + ASSERT(ret); int32_t nIndex = -1; pNode->m_pParent = this; |