summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordsinclair <dsinclair@chromium.org>2016-05-16 08:11:18 -0700
committerCommit bot <commit-bot@chromium.org>2016-05-16 08:11:18 -0700
commit719a7a71d4cf1b714ad7f76e5f9ca28cfd5b74d3 (patch)
treef555447239f7c308c2a8ea8b005d552d11349632
parent71a452f8ce12e31cc4e0d8c7878567b0c7fc63c2 (diff)
downloadpdfium-719a7a71d4cf1b714ad7f76e5f9ca28cfd5b74d3.tar.xz
Readme update to make need for pdfium_is_standalone clear.
Add a note about the need for pdfium_is_standalone and fix some spelling mistakes along the way. Review-Url: https://codereview.chromium.org/1979243002
-rw-r--r--README.md9
1 files changed, 6 insertions, 3 deletions
diff --git a/README.md b/README.md
index fb1498f64d..dbbed5be62 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@ if you need to use the system toolchain. See
Get the chromium depot tools via the instructions at
http://www.chromium.org/developers/how-tos/install-depot-tools (this provides
-the gclient utilty needed below).
+the gclient utility needed below).
Also install Python, Subversion, and Git and make sure they're in your path.
@@ -76,7 +76,7 @@ gn gen <directory>
If you want to set <directory> to `out/Debug` or `out/Release` you'll need to
export `GYP_PDFIUM_NO_ACTION=1` to stop `gclient sync` from executing GYP
-and overwritting your build files.
+and overwriting your build files.
###<a name="BuildConfig"></a> Selecting build configuration
@@ -85,7 +85,7 @@ or without XFA forms support. Both of these features are enabled by
default. Also note that the XFA feature requires JavaScript.
Configuration is done by executing `gn args <directory>` to configure the build.
-This will lauch an editor in which you can set the following arguments.
+This will launch an editor in which you can set the following arguments.
```
use_goma = true # Googlers only.
@@ -100,6 +100,9 @@ pdf_is_standalone = true # Set for a non-embedded build.
clang_use_chrome_plugins = false # Currently must be false.
```
+Note, you must set `pdf_is_standalone = true` if you want the sample
+applications like `pdfium_test` to build.
+
When complete the arguments will be stored in `<directory>/args.gn`.
## Building the code