diff options
| author | Dominik Röttsches <drott@chromium.org> | 2017-04-21 15:36:32 +0300 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-21 18:13:39 +0000 |
| commit | 6058730c73c78db9ec710f3b4165526acdf19e9f (patch) | |
| tree | 16a0364e918ec58636ab7afa7174c99ad7b46dd3 | |
| parent | e247ec47b75d45d16298e4e11ba68745b9ebe3eb (diff) | |
| download | pdfium-6058730c73c78db9ec710f3b4165526acdf19e9f.tar.xz | |
Fix Visual Studio build from GN generated files
VS does not like to see <, > in the XML nodes of the build files. Work
around this issue by replacing less-than and greater-than characters in
the FreeType custom config include file path definitions with escaped
quotes.
BUG=pdfium:701
Change-Id: I879ade670158ccb4d435b65cde382c6e6b32e002
Reviewed-on: https://pdfium-review.googlesource.com/4330
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
| -rw-r--r-- | third_party/BUILD.gn | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/third_party/BUILD.gn b/third_party/BUILD.gn index c270a1063a..7730212c75 100644 --- a/third_party/BUILD.gn +++ b/third_party/BUILD.gn @@ -64,8 +64,11 @@ if (pdf_bundle_freetype) { "//third_party/freetype/src/include", ] defines = [ - "FT_CONFIG_MODULES_H=<freetype-custom-config/ftmodule.h>", - "FT_CONFIG_OPTIONS_H=<freetype-custom-config/ftoption.h>", + # GN currently does not escape '<' and '>' when generating xml based + # Visual Studio project files. As a result, use quotes instead of pointy + # brackets in these defines. + "FT_CONFIG_MODULES_H=\"freetype-custom-config/ftmodule.h\"", + "FT_CONFIG_OPTIONS_H=\"freetype-custom-config/ftoption.h\"", ] } |