summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordan sinclair <dsinclair@chromium.org>2017-05-24 22:10:03 -0400
committerChromium commit bot <commit-bot@chromium.org>2017-05-25 14:01:12 +0000
commita7c9c0127f47b9dd9768ca4c256a269ab1c07a86 (patch)
treedbb3f5578edc563b2f5270046a14a700ca7c0c2d
parent1603c7fedd7b7d5fc3a98972f30ab743c00f234d (diff)
downloadpdfium-a7c9c0127f47b9dd9768ca4c256a269ab1c07a86.tar.xz
Enable remaining boolean FM2JSContext tests
This CL updates the return type of the remaining boolean tests to be Integer and enables the tests. Change-Id: Ie2856ad31d17ffb496f33e6969912d0aae9678c5 Reviewed-on: https://pdfium-review.googlesource.com/5895 Reviewed-by: Nicolás Peña <npm@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org>
-rw-r--r--xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp b/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp
index d0d657ee50..a61203cc0b 100644
--- a/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp
+++ b/xfa/fxfa/fm2js/cxfa_fm2jscontext_embeddertest.cpp
@@ -829,7 +829,7 @@ TEST_F(FM2JSContextEmbedderTest, Exists) {
EXPECT_FALSE(value->ToBoolean());
}
-TEST_F(FM2JSContextEmbedderTest, DISABLED_HasValue) {
+TEST_F(FM2JSContextEmbedderTest, HasValue) {
ASSERT_TRUE(OpenDocument("simple_xfa.pdf"));
struct {
@@ -841,13 +841,13 @@ TEST_F(FM2JSContextEmbedderTest, DISABLED_HasValue) {
EXPECT_TRUE(Execute(tests[i].program));
CFXJSE_Value* value = GetValue();
- EXPECT_TRUE(value->IsBoolean()) << "Program: " << tests[i].program;
+ EXPECT_TRUE(value->IsInteger()) << "Program: " << tests[i].program;
EXPECT_EQ(tests[i].result, value->ToBoolean())
<< "Program: " << tests[i].program;
}
}
-TEST_F(FM2JSContextEmbedderTest, DISABLED_Oneof) {
+TEST_F(FM2JSContextEmbedderTest, Oneof) {
ASSERT_TRUE(OpenDocument("simple_xfa.pdf"));
struct {
@@ -863,13 +863,13 @@ TEST_F(FM2JSContextEmbedderTest, DISABLED_Oneof) {
EXPECT_TRUE(Execute(tests[i].program));
CFXJSE_Value* value = GetValue();
- EXPECT_TRUE(value->IsBoolean()) << "Program: " << tests[i].program;
+ EXPECT_TRUE(value->IsInteger()) << "Program: " << tests[i].program;
EXPECT_EQ(tests[i].result, value->ToBoolean())
<< "Program: " << tests[i].program;
}
}
-TEST_F(FM2JSContextEmbedderTest, DISABLED_Within) {
+TEST_F(FM2JSContextEmbedderTest, Within) {
ASSERT_TRUE(OpenDocument("simple_xfa.pdf"));
struct {
@@ -883,7 +883,7 @@ TEST_F(FM2JSContextEmbedderTest, DISABLED_Within) {
EXPECT_TRUE(Execute(tests[i].program));
CFXJSE_Value* value = GetValue();
- EXPECT_TRUE(value->IsBoolean()) << "Program: " << tests[i].program;
+ EXPECT_TRUE(value->IsInteger()) << "Program: " << tests[i].program;
EXPECT_EQ(tests[i].result, value->ToBoolean())
<< "Program: " << tests[i].program;
}