diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-04-17 17:59:58 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-17 17:59:58 +0000 |
| commit | 8b4a3c7ef32b2ffb4874e4cc65b38ee555d8806e (patch) | |
| tree | 241abd93b51b9c0d0f0a05c20092a3a1749af8a4 /BUILD.gn | |
| parent | 1dbfe996b946f0d2a1afc52669ff5fca22a85070 (diff) | |
| download | pdfium-8b4a3c7ef32b2ffb4874e4cc65b38ee555d8806e.tar.xz | |
Use span in CXFA_LocaleValue::GetDoubleNum()chromium/3399
Get runtime checks instead of just asserts.
Use early return while at it to save some indentation.
Fix one out-of-bounds case noted by inspection.
Add tests, and fix bugs that gave the wrong answers.
This should be removed at our earliest convenience. Its likely to
still be wrong.
Change-Id: I2a68edc854c8b28c434fe28397b7834e5c9c3670
Reviewed-on: https://pdfium-review.googlesource.com/30530
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -2929,6 +2929,7 @@ test("pdfium_unittests") { "xfa/fxfa/fm2js/cxfa_fmlexer_unittest.cpp", "xfa/fxfa/fm2js/cxfa_fmparser_unittest.cpp", "xfa/fxfa/fm2js/cxfa_fmsimpleexpression_unittest.cpp", + "xfa/fxfa/parser/cxfa_localevalue_unittest.cpp", "xfa/fxfa/parser/cxfa_node_unittest.cpp", "xfa/fxfa/parser/cxfa_nodeiteratortemplate_unittest.cpp", "xfa/fxfa/parser/cxfa_xmllocale_unittest.cpp", |