summaryrefslogtreecommitdiff
path: root/BUILD.gn
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-10-15 23:49:48 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-10-15 23:49:48 +0000
commita996ff444d4bf57a78d59dde59b280ca0542962a (patch)
tree8bc65bb923cf3f2932a9598002db2652ab7a48b3 /BUILD.gn
parentf03f7810c30cb3d01517c0efc189d68e440c9162 (diff)
downloadpdfium-a996ff444d4bf57a78d59dde59b280ca0542962a.tar.xz
Move fx_skia_device_unittest.cpp to pdfium_embeddertests.
It uses fpdfsdk/ and public/ code from core/. Also sort some conditionals in BUILD.gn. Change-Id: I4da9dc1f1833fa6644be3da1a935beba1d57cb2f Reviewed-on: https://pdfium-review.googlesource.com/c/43996 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'BUILD.gn')
-rw-r--r--BUILD.gn42
1 files changed, 23 insertions, 19 deletions
diff --git a/BUILD.gn b/BUILD.gn
index fc61dce6a8..fc06c82a74 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -251,6 +251,19 @@ test("pdfium_unittests") {
"//testing/gtest",
]
configs += [ ":pdfium_core_config" ]
+
+ if (is_android) {
+ use_raw_android_executable = true
+ }
+
+ if (pdf_enable_v8) {
+ configs += [ "//v8:external_startup_data" ]
+ deps += [
+ "fxjs:unittests",
+ "//v8",
+ ]
+ }
+
if (pdf_enable_xfa) {
deps += [
"fxbarcode:unittests",
@@ -263,22 +276,6 @@ test("pdfium_unittests") {
"xfa/fxfa/parser:unittests",
]
}
-
- # TODO(thestig): Should this be an embeddertest?
- if (pdf_use_skia || pdf_use_skia_paths) {
- sources += [ "core/fxge/skia/fx_skia_device_unittest.cpp" ]
- deps += [ "//skia" ]
- }
- if (pdf_enable_v8) {
- configs += [ "//v8:external_startup_data" ]
- deps += [
- "fxjs:unittests",
- "//v8",
- ]
- }
- if (is_android) {
- use_raw_android_executable = true
- }
}
test("pdfium_embeddertests") {
@@ -335,6 +332,11 @@ test("pdfium_embeddertests") {
include_dirs = [ "testing/gmock/include" ]
configs += [ ":pdfium_core_config" ]
+ if (is_android) {
+ ignore_all_data_deps = true
+ use_raw_android_executable = true
+ }
+
if (pdf_enable_v8) {
sources += [
"fxjs/cfxjs_engine_embeddertest.cpp",
@@ -345,6 +347,7 @@ test("pdfium_embeddertests") {
deps += [ "fxjs" ]
configs += [ "//v8:external_startup_data" ]
}
+
if (pdf_enable_xfa) {
sources += [
"fxjs/cfxjse_formcalc_context_embeddertest.cpp",
@@ -354,9 +357,10 @@ test("pdfium_embeddertests") {
"xfa/fxfa/parser/cxfa_document_parser_embeddertest.cpp",
]
}
- if (is_android) {
- ignore_all_data_deps = true
- use_raw_android_executable = true
+
+ if (pdf_use_skia || pdf_use_skia_paths) {
+ sources += [ "core/fxge/skia/fx_skia_device_embeddertest.cpp" ]
+ deps += [ "//skia" ]
}
}