summaryrefslogtreecommitdiff
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2016-03-09 09:59:23 -0500
committerDan Sinclair <dsinclair@chromium.org>2016-03-09 09:59:23 -0500
commit3ebd121d45ceb08918a3dcb5b3b7ac29448c862f (patch)
tree361d5fa0f9be7484cce4aace1b9cc18545046611 /PRESUBMIT.py
parent317758574e173367b41928a1575d70600c6b6ea8 (diff)
downloadpdfium-3ebd121d45ceb08918a3dcb5b3b7ac29448c862f.tar.xz
Review and cleanup lint warnings.
This CL goes through the remaining list of list warnings and records why they are currently blacklisted, or fixes and enables them. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773733002 .
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py18
1 files changed, 11 insertions, 7 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 7c8f8f439b..71d6b6f7b3 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -9,24 +9,28 @@ for more details about the presubmit API built into depot_tools.
"""
LINT_FILTERS = [
+ # Rvalue ref checks are unreliable.
'-build/c++11',
+ # Need to fix header names not matching cpp names.
'-build/include',
+ # Need to fix header names not matching cpp names.
'-build/include_order',
- '-build/include_what_you_use',
- '-build/namespaces',
- '-build/storage_class',
+ # Too many to fix at the moment.
'-readability/casting',
+ # Need to refactor large methods to fix.
'-readability/fn_size',
- '-readability/todo',
- '-readability/utf8',
- '-runtime/arrays',
+ # Need to fix errors when making methods explicit.
'-runtime/explicit',
+ # Lots of usage to fix first.
'-runtime/int',
+ # Need to fix two snprintf TODOs
'-runtime/printf',
+ # Lots of non-const references need to be fixed
'-runtime/references',
+ # We are not thread safe, so this will never pass.
'-runtime/threadsafe_fn',
+ # Figure out how to deal with #defines that git cl format creates.
'-whitespace/indent',
- '-whitespace/line_length',
]
def CheckChangeOnUpload(input_api, output_api):