summaryrefslogtreecommitdiff
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authorDan Sinclair <dsinclair@chromium.org>2016-03-14 15:07:39 -0400
committerDan Sinclair <dsinclair@chromium.org>2016-03-14 15:07:39 -0400
commit544bbc6d81ee9d94a09809830b3f622f2dbad28a (patch)
tree8f185de3097fbe7d220ba804829fe793e1ee301c /PRESUBMIT.py
parent1770c021cf998ff1b33855b1397f6ea8ff9f7cd7 (diff)
downloadpdfium-544bbc6d81ee9d94a09809830b3f622f2dbad28a.tar.xz
Add missing DEPS files; enable checkdeps.
This CL adds the needed DEPS files to make checkdeps pass correctly. The checkdeps PRESUBMIT method has been copied from Chromium and is enabled on CL upload. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1801923002 .
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py57
1 files changed, 57 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 71d6b6f7b3..819c4e64fd 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -33,9 +33,66 @@ LINT_FILTERS = [
'-whitespace/indent',
]
+
+def _CheckUnwantedDependencies(input_api, output_api):
+ """Runs checkdeps on #include statements added in this
+ change. Breaking - rules is an error, breaking ! rules is a
+ warning.
+ """
+ import sys
+ # We need to wait until we have an input_api object and use this
+ # roundabout construct to import checkdeps because this file is
+ # eval-ed and thus doesn't have __file__.
+ original_sys_path = sys.path
+ try:
+ sys.path = sys.path + [input_api.os_path.join(
+ input_api.PresubmitLocalPath(), 'buildtools', 'checkdeps')]
+ import checkdeps
+ from cpp_checker import CppChecker
+ from rules import Rule
+ finally:
+ # Restore sys.path to what it was before.
+ sys.path = original_sys_path
+
+ added_includes = []
+ for f in input_api.AffectedFiles():
+ if not CppChecker.IsCppFile(f.LocalPath()):
+ continue
+
+ changed_lines = [line for line_num, line in f.ChangedContents()]
+ added_includes.append([f.LocalPath(), changed_lines])
+
+ deps_checker = checkdeps.DepsChecker(input_api.PresubmitLocalPath())
+
+ error_descriptions = []
+ warning_descriptions = []
+ for path, rule_type, rule_description in deps_checker.CheckAddedCppIncludes(
+ added_includes):
+ description_with_path = '%s\n %s' % (path, rule_description)
+ if rule_type == Rule.DISALLOW:
+ error_descriptions.append(description_with_path)
+ else:
+ warning_descriptions.append(description_with_path)
+
+ results = []
+ if error_descriptions:
+ results.append(output_api.PresubmitError(
+ 'You added one or more #includes that violate checkdeps rules.',
+ error_descriptions))
+ if warning_descriptions:
+ results.append(output_api.PresubmitPromptOrNotify(
+ 'You added one or more #includes of files that are temporarily\n'
+ 'allowed but being removed. Can you avoid introducing the\n'
+ '#include? See relevant DEPS file(s) for details and contacts.',
+ warning_descriptions))
+ return results
+
+
def CheckChangeOnUpload(input_api, output_api):
results = []
+ results += _CheckUnwantedDependencies(input_api, output_api)
results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
results += input_api.canned_checks.CheckChangeLintsClean(
input_api, output_api, None, LINT_FILTERS)
+
return results