diff options
| author | Lei Zhang <thestig@chromium.org> | 2017-08-02 17:41:22 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-08-03 01:05:51 +0000 |
| commit | d1a8458e6390103e123e9d265040b3d02c16955b (patch) | |
| tree | 3b169237c62b6b6210722ed403314b52aea34d8f /core/fpdfapi/parser/fpdf_parser_utility.cpp | |
| parent | f44812cf6d7559dd2a0bbc25a684e54675f4794d (diff) | |
| download | pdfium-d1a8458e6390103e123e9d265040b3d02c16955b.tar.xz | |
Avoid a redundant header offset check in CPDF_Parser.
CPDF_Parser::StartLinearizedParse() calls StartParse(), but already
knows the PDF header offset. Refactor StartParse() so it does not have
to look for the header again.
Change-Id: Id8cc39301ae72da868dafc53921622d5b28ce26e
Reviewed-on: https://pdfium-review.googlesource.com/9830
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Art Snake <art-snake@yandex-team.ru>
Diffstat (limited to 'core/fpdfapi/parser/fpdf_parser_utility.cpp')
| -rw-r--r-- | core/fpdfapi/parser/fpdf_parser_utility.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fpdfapi/parser/fpdf_parser_utility.cpp b/core/fpdfapi/parser/fpdf_parser_utility.cpp index 8323426e74..0c0ca6644f 100644 --- a/core/fpdfapi/parser/fpdf_parser_utility.cpp +++ b/core/fpdfapi/parser/fpdf_parser_utility.cpp @@ -75,12 +75,12 @@ int32_t GetHeaderOffset(const CFX_RetainPtr<IFX_SeekableReadStream>& pFile) { uint8_t buf[kBufSize]; for (int32_t offset = 0; offset <= 1024; ++offset) { if (!pFile->ReadBlock(buf, offset, kBufSize)) - return -1; + return kInvalidHeaderOffset; if (memcmp(buf, "%PDF", 4) == 0) return offset; } - return -1; + return kInvalidHeaderOffset; } int32_t GetDirectInteger(CPDF_Dictionary* pDict, const CFX_ByteString& key) { |