diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-07-02 19:23:53 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-07-02 19:23:53 +0000 |
| commit | 61ff9b659a5b992e3e3ba4000f7ca5c799cc9ebf (patch) | |
| tree | 327481dc21ffd9ea01676e9a174cf1a616fee5be /core/fpdfapi | |
| parent | 319ef06b2f695c7ebc26985d477b71fe8db93d3e (diff) | |
| download | pdfium-61ff9b659a5b992e3e3ba4000f7ca5c799cc9ebf.tar.xz | |
Comment some raw pointers that cant become UnownedPtr<>.
These appear in compile-time const data. Adding the comment makes
it easier to see what work remains when using grep.
Change-Id: Ibb5fe920dc9fc99dd4c866f9ddf800a58f6a67a8
Reviewed-on: https://pdfium-review.googlesource.com/36690
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fpdfapi')
| -rw-r--r-- | core/fpdfapi/cmaps/cmap_int.h | 6 | ||||
| -rw-r--r-- | core/fpdfapi/font/cpdf_cmap.cpp | 2 | ||||
| -rw-r--r-- | core/fpdfapi/font/cpdf_type1font.cpp | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/core/fpdfapi/cmaps/cmap_int.h b/core/fpdfapi/cmaps/cmap_int.h index 27f9617ed6..03650383cd 100644 --- a/core/fpdfapi/cmaps/cmap_int.h +++ b/core/fpdfapi/cmaps/cmap_int.h @@ -20,9 +20,9 @@ struct FXCMAP_DWordCIDMap { struct FXCMAP_CMap { enum MapType : uint8_t { Single, Range }; - const char* m_Name; - const uint16_t* m_pWordMap; - const FXCMAP_DWordCIDMap* m_pDWordMap; + const char* m_Name; // Raw, POD struct. + const uint16_t* m_pWordMap; // Raw, POD struct. + const FXCMAP_DWordCIDMap* m_pDWordMap; // Raw, POD struct. uint16_t m_WordCount; uint16_t m_DWordCount; MapType m_WordMapType; diff --git a/core/fpdfapi/font/cpdf_cmap.cpp b/core/fpdfapi/font/cpdf_cmap.cpp index c761959d8b..f3ef829e20 100644 --- a/core/fpdfapi/font/cpdf_cmap.cpp +++ b/core/fpdfapi/font/cpdf_cmap.cpp @@ -23,7 +23,7 @@ struct ByteRange { }; struct PredefinedCMap { - const char* m_pName; + const char* m_pName; // Raw, POD struct. CIDSet m_Charset; CIDCoding m_Coding; CPDF_CMap::CodingScheme m_CodingScheme; diff --git a/core/fpdfapi/font/cpdf_type1font.cpp b/core/fpdfapi/font/cpdf_type1font.cpp index 8c286edcd0..fb445832f0 100644 --- a/core/fpdfapi/font/cpdf_type1font.cpp +++ b/core/fpdfapi/font/cpdf_type1font.cpp @@ -20,8 +20,8 @@ namespace { #if _FX_PLATFORM_ == _FX_PLATFORM_APPLE_ struct GlyphNameMap { - const char* m_pStrAdobe; - const char* m_pStrUnicode; + const char* m_pStrAdobe; // Raw, POD struct. + const char* m_pStrUnicode; // Raw, POD struct. }; const GlyphNameMap g_GlyphNameSubsts[] = {{"ff", "uniFB00"}, |