diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-04-04 14:37:18 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-04 21:48:48 +0000 |
| commit | afd0d1f488ea55da545b3310fd8f22e45522a695 (patch) | |
| tree | 89136eba4669421b6f828edb9f3d69ee558110d0 /core/fpdfdoc | |
| parent | 4f8b044b95dc282959dfe41453e2a9c1ec7e9354 (diff) | |
| download | pdfium-afd0d1f488ea55da545b3310fd8f22e45522a695.tar.xz | |
RefCount CPDF_StreamAcc all the time.
Pass stream argument to constructor; it feels like a
stream accessor should always be made from a stream rather
than passing one in after the fact.
Change-Id: Iaa46cb37677b81f0170f5d39bab76ad38ea4af44
Reviewed-on: https://pdfium-review.googlesource.com/3620
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fpdfdoc')
| -rw-r--r-- | core/fpdfdoc/cpdf_metadata.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/core/fpdfdoc/cpdf_metadata.cpp b/core/fpdfdoc/cpdf_metadata.cpp index 3780d1587d..5379275544 100644 --- a/core/fpdfdoc/cpdf_metadata.cpp +++ b/core/fpdfdoc/cpdf_metadata.cpp @@ -20,9 +20,9 @@ CPDF_Metadata::CPDF_Metadata(CPDF_Document* pDoc) { if (!pStream) return; - CPDF_StreamAcc acc; - acc.LoadAllData(pStream, false); - m_pXmlElement = CXML_Element::Parse(acc.GetData(), acc.GetSize()); + auto pAcc = pdfium::MakeRetain<CPDF_StreamAcc>(pStream); + pAcc->LoadAllData(false); + m_pXmlElement = CXML_Element::Parse(pAcc->GetData(), pAcc->GetSize()); } CPDF_Metadata::~CPDF_Metadata() {} |