diff options
| author | weili <weili@chromium.org> | 2016-06-03 11:22:16 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-06-03 11:22:16 -0700 |
| commit | 12367cb5e83e771cd67948c810fdd5f63d61af87 (patch) | |
| tree | 47daac780e5c028ba531830b514c0c60102f1368 /core/fxcodec/codec/fx_codec_png.cpp | |
| parent | 79d798da0d4b5f9f1fc27917102bdd7bcfbe863e (diff) | |
| download | pdfium-12367cb5e83e771cd67948c810fdd5f63d61af87.tar.xz | |
Fix some code which causes warnings when compiled by /analyze tool
The code may not cause error conditions, but can be improved. These
warnings include uninitialized variables, signed/unsigned mismatch,
redundant condition, and using bool in arithmetic operations.
Also remove a chunk of unused code.
BUG=chromium:613623, chromium:427616
Review-Url: https://codereview.chromium.org/2036203004
Diffstat (limited to 'core/fxcodec/codec/fx_codec_png.cpp')
| -rw-r--r-- | core/fxcodec/codec/fx_codec_png.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fxcodec/codec/fx_codec_png.cpp b/core/fxcodec/codec/fx_codec_png.cpp index 61d4cebdbb..f7b922973e 100644 --- a/core/fxcodec/codec/fx_codec_png.cpp +++ b/core/fxcodec/codec/fx_codec_png.cpp @@ -56,7 +56,7 @@ static void _png_load_bmp_attribute(png_structp png_ptr, if (t) { FXSYS_memset(pAttribute->m_strTime, 0, sizeof(pAttribute->m_strTime)); FXSYS_snprintf((FX_CHAR*)pAttribute->m_strTime, - sizeof(pAttribute->m_strTime), "%4d:%2d:%2d %2d:%2d:%2d", + sizeof(pAttribute->m_strTime), "%4u:%2u:%2u %2u:%2u:%2u", t->year, t->month, t->day, t->hour, t->minute, t->second); pAttribute->m_strTime[sizeof(pAttribute->m_strTime) - 1] = 0; bTime = 1; |