diff options
author | Tom Sepez <tsepez@chromium.org> | 2018-08-30 22:23:37 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-30 22:23:37 +0000 |
commit | 3b83e83fbfd24e521f7ecd7ce7f1019769bcaec7 (patch) | |
tree | c8aa119940a263837b589035f0f09111577d8926 /core/fxcodec/codec/fx_codec_rle_unittest.cpp | |
parent | 07388cae6fb525ccecc20f66ce530ac52d30d754 (diff) | |
download | pdfium-3b83e83fbfd24e521f7ecd7ce7f1019769bcaec7.tar.xz |
Use pdfium::span<> arg in A85 and RLE encoder methods
Change-Id: Iff900bc3e1cd9c9dd6b023230c1feba78759581c
Reviewed-on: https://pdfium-review.googlesource.com/41710
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxcodec/codec/fx_codec_rle_unittest.cpp')
-rw-r--r-- | core/fxcodec/codec/fx_codec_rle_unittest.cpp | 66 |
1 files changed, 25 insertions, 41 deletions
diff --git a/core/fxcodec/codec/fx_codec_rle_unittest.cpp b/core/fxcodec/codec/fx_codec_rle_unittest.cpp index 47067cb030..62ea4e7a76 100644 --- a/core/fxcodec/codec/fx_codec_rle_unittest.cpp +++ b/core/fxcodec/codec/fx_codec_rle_unittest.cpp @@ -14,34 +14,27 @@ TEST(fxcodec, RLETestBadInputs) { const uint8_t src_buf[] = {1}; uint8_t* dest_buf = nullptr; - uint32_t src_size = 4; uint32_t dest_size = 0; CCodec_BasicModule* pEncoders = CCodec_ModuleMgr().GetBasicModule(); EXPECT_TRUE(pEncoders); // Error codes, not segvs, should callers pass us a nullptr pointer. - EXPECT_FALSE( - pEncoders->RunLengthEncode(src_buf, src_size, &dest_buf, nullptr)); - EXPECT_FALSE( - pEncoders->RunLengthEncode(src_buf, src_size, nullptr, &dest_size)); - EXPECT_FALSE(pEncoders->RunLengthEncode(src_buf, 0, &dest_buf, &dest_size)); - EXPECT_FALSE( - pEncoders->RunLengthEncode(nullptr, src_size, &dest_buf, &dest_size)); + EXPECT_FALSE(pEncoders->RunLengthEncode(src_buf, &dest_buf, nullptr)); + EXPECT_FALSE(pEncoders->RunLengthEncode(src_buf, nullptr, &dest_size)); + EXPECT_FALSE(pEncoders->RunLengthEncode({}, &dest_buf, &dest_size)); } // Check length 1 input works. Check terminating character is applied. TEST(fxcodec, RLETestShortInput) { const uint8_t src_buf[] = {1}; uint8_t* dest_buf = nullptr; - uint32_t src_size = 1; uint32_t dest_size = 0; CCodec_BasicModule* pEncoders = CCodec_ModuleMgr().GetBasicModule(); EXPECT_TRUE(pEncoders); - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf, &dest_buf, &dest_size)); ASSERT_EQ(3u, dest_size); EXPECT_EQ(0, dest_buf[0]); EXPECT_EQ(1, dest_buf[1]); @@ -62,7 +55,6 @@ TEST(fxcodec, RLETestNormalInputs) { // Non-match, match const uint8_t src_buf_3[] = {1, 2, 3, 4, 5, 3, 3, 3, 3, 3}; - uint32_t src_size = 10; uint32_t dest_size = 0; uint8_t* dest_buf = nullptr; @@ -70,13 +62,12 @@ TEST(fxcodec, RLETestNormalInputs) { EXPECT_TRUE(pEncoders); // Case 1: - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_1, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_1, &dest_buf, &dest_size)); uint8_t* decoded_buf = nullptr; uint32_t decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_1), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_1[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); @@ -84,13 +75,12 @@ TEST(fxcodec, RLETestNormalInputs) { // Case 2: dest_buf = nullptr; dest_size = 0; - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_2, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_2, &dest_buf, &dest_size)); decoded_buf = nullptr; decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_2), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_2[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); @@ -98,13 +88,12 @@ TEST(fxcodec, RLETestNormalInputs) { // Case 3: dest_buf = nullptr; dest_size = 0; - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_3, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_3, &dest_buf, &dest_size)); decoded_buf = nullptr; decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_3), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_3[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); @@ -131,7 +120,6 @@ TEST(fxcodec, RLETestFullLengthInputs) { for (uint16_t i = 0; i < 260; i++) src_buf_4[i] = (uint8_t)(i); - uint32_t src_size = 260; uint32_t dest_size = 0; uint8_t* dest_buf = nullptr; @@ -139,13 +127,12 @@ TEST(fxcodec, RLETestFullLengthInputs) { EXPECT_TRUE(pEncoders); // Case 1: - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_1, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_1, &dest_buf, &dest_size)); uint8_t* decoded_buf = nullptr; uint32_t decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_1), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_1[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); @@ -153,13 +140,12 @@ TEST(fxcodec, RLETestFullLengthInputs) { // Case 2: dest_buf = nullptr; dest_size = 0; - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_2, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_2, &dest_buf, &dest_size)); decoded_buf = nullptr; decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_2), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_2[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); @@ -167,13 +153,12 @@ TEST(fxcodec, RLETestFullLengthInputs) { // Case 3: dest_buf = nullptr; dest_size = 0; - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_3, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_3, &dest_buf, &dest_size)); decoded_buf = nullptr; decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_3), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_3[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); @@ -181,13 +166,12 @@ TEST(fxcodec, RLETestFullLengthInputs) { // Case 4: dest_buf = nullptr; dest_size = 0; - EXPECT_TRUE( - pEncoders->RunLengthEncode(src_buf_4, src_size, &dest_buf, &dest_size)); + EXPECT_TRUE(pEncoders->RunLengthEncode(src_buf_4, &dest_buf, &dest_size)); decoded_buf = nullptr; decoded_size = 0; RunLengthDecode({dest_buf, dest_size}, &decoded_buf, &decoded_size); - ASSERT_EQ(src_size, decoded_size); - for (uint32_t i = 0; i < src_size; i++) + ASSERT_EQ(sizeof(src_buf_4), decoded_size); + for (uint32_t i = 0; i < decoded_size; i++) EXPECT_EQ(src_buf_4[i], decoded_buf[i]) << " at " << i; FX_Free(dest_buf); FX_Free(decoded_buf); |