diff options
| author | Tom Sepez <tsepez@chromium.org> | 2017-03-28 14:09:43 -0700 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-03-28 21:28:39 +0000 |
| commit | 3bb57514867a2bd10ba535e0b06de566a58d8085 (patch) | |
| tree | 8c3019986ee23a0bec05955f861cee3b73b3770d /core/fxcrt/cfx_retain_ptr.h | |
| parent | 022ded02d2c23a8d043bbcb3d3f37dab12636759 (diff) | |
| download | pdfium-3bb57514867a2bd10ba535e0b06de566a58d8085.tar.xz | |
Ensure that CFX_RetainPtr move ctor is used by std::vector.
Add a test for one of our types that fails unless this is the case.
Mark all our other move ctors as |noexcept|.
Change-Id: Ib106f219183d5abf94504af420a43c94b8f40e22
Reviewed-on: https://pdfium-review.googlesource.com/3251
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'core/fxcrt/cfx_retain_ptr.h')
| -rw-r--r-- | core/fxcrt/cfx_retain_ptr.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fxcrt/cfx_retain_ptr.h b/core/fxcrt/cfx_retain_ptr.h index 5db384f334..32a77c5a6c 100644 --- a/core/fxcrt/cfx_retain_ptr.h +++ b/core/fxcrt/cfx_retain_ptr.h @@ -22,7 +22,7 @@ class CFX_RetainPtr { CFX_RetainPtr() {} CFX_RetainPtr(const CFX_RetainPtr& that) : CFX_RetainPtr(that.Get()) {} - CFX_RetainPtr(CFX_RetainPtr&& that) { Swap(that); } + CFX_RetainPtr(CFX_RetainPtr&& that) noexcept { Swap(that); } // Deliberately implicit to allow returning nullptrs. CFX_RetainPtr(std::nullptr_t ptr) {} |