summaryrefslogtreecommitdiff
path: root/core/fxcrt/cfx_string_data_template.h
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-09-22 11:37:13 -0700
committerCommit bot <commit-bot@chromium.org>2016-09-22 11:37:13 -0700
commitfef62e1f2bbf064100e6e262a10653f2374bfd2b (patch)
tree5532d2a9d2fd82a1c9ccdfc9141b65af60897313 /core/fxcrt/cfx_string_data_template.h
parent8e0638b1531493e2d5fe3a603f4be60418c78bc4 (diff)
downloadpdfium-fef62e1f2bbf064100e6e262a10653f2374bfd2b.tar.xz
Null CPDF_CountedObj::m_pObj prior to deletion
This gives additional protection in case of re-entry. Also make CFX_CountRef more robust in face of errors. BUG=649229 Review-Url: https://codereview.chromium.org/2364673002
Diffstat (limited to 'core/fxcrt/cfx_string_data_template.h')
-rw-r--r--core/fxcrt/cfx_string_data_template.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fxcrt/cfx_string_data_template.h b/core/fxcrt/cfx_string_data_template.h
index 225020a7dd..5f7bfa1f83 100644
--- a/core/fxcrt/cfx_string_data_template.h
+++ b/core/fxcrt/cfx_string_data_template.h
@@ -85,7 +85,7 @@ class CFX_StringDataTemplate {
// Since the count increments with each new pointer, the largest value is
// the number of pointers that can fit into the address space. The size of
// the address space itself is a good upper bound on it.
- intptr_t m_nRefs; // Would prefer ssize_t, but no windows support.
+ intptr_t m_nRefs;
// |FX_STRSIZE| is currently typedef'd as |int|.
// TODO(palmer): It should be a |size_t|, or at least unsigned.