summaryrefslogtreecommitdiff
path: root/core/fxcrt/fx_string.cpp
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-06-08 23:47:01 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-06-08 23:47:01 +0000
commit821ae927144152a5122d602753907bd423aa06d0 (patch)
tree4835f5818829c9cf99ab653aec46dfe107b35daa /core/fxcrt/fx_string.cpp
parent83b259e52ce289003b1a88ba6d8d5e2a8ac348fe (diff)
downloadpdfium-821ae927144152a5122d602753907bd423aa06d0.tar.xz
Avoid undefined behavior in FX_atonum().
BUG=chromium:664730 Change-Id: Ie46221382ffed7a16366c484c249d2571c7be5c4 Reviewed-on: https://pdfium-review.googlesource.com/34696 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxcrt/fx_string.cpp')
-rw-r--r--core/fxcrt/fx_string.cpp11
1 files changed, 9 insertions, 2 deletions
diff --git a/core/fxcrt/fx_string.cpp b/core/fxcrt/fx_string.cpp
index 83d0e6d906..daf995560b 100644
--- a/core/fxcrt/fx_string.cpp
+++ b/core/fxcrt/fx_string.cpp
@@ -9,6 +9,7 @@
#include "core/fxcrt/fx_extension.h"
#include "core/fxcrt/fx_string.h"
+#include "third_party/base/compiler_specific.h"
namespace {
@@ -133,8 +134,14 @@ bool FX_atonum(const ByteStringView& strc, void* pData) {
// Switch back to the int space so we can flip to a negative if we need.
uint32_t uValue = integer.ValueOrDefault(0);
int32_t value = static_cast<int>(uValue);
- if (bNegative)
- value = -value;
+ if (bNegative) {
+ // |value| is usually positive, except in the corner case of "-2147483648",
+ // where |uValue| is 2147483648. When it gets casted to an int, |value|
+ // becomes -2147483648. For this case, avoid undefined behavior, because an
+ // integer cannot represent 2147483648.
+ static constexpr int kMinInt = std::numeric_limits<int>::min();
+ value = LIKELY(value != kMinInt) ? -value : kMinInt;
+ }
int* pInt = static_cast<int*>(pData);
*pInt = value;