diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-09-04 19:41:51 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-09-04 19:41:51 +0000 |
| commit | 73e97f4fac2f4f591ff62e70377a80fd40b5f6f3 (patch) | |
| tree | 712832dc07e46f8e599975bc190055b859f62079 /core/fxcrt/unowned_ptr_unittest.cpp | |
| parent | 6b2e2f0ec7c5f629c5270d14c2339197af7392d8 (diff) | |
| download | pdfium-73e97f4fac2f4f591ff62e70377a80fd40b5f6f3.tar.xz | |
Avoid CHECK in fpdf_parser_decode.cpp (memcpy empty span)
Given a span of size N, memcpy(dest, &span[N], 0) ought to be a no-op,
but since we compute span[N] before checking for zero length, we hit
an assert. The correct idiom should be to create a sub-span, which
allows specifying N, but only when the size is 0.
Bug: 879910
Change-Id: Ic6f368109a5c2f1e13a5f638c6a233769e2ad41b
Reviewed-on: https://pdfium-review.googlesource.com/41930
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fxcrt/unowned_ptr_unittest.cpp')
0 files changed, 0 insertions, 0 deletions