Add unit test for CFX_SAXReader.

Make the pending re-write CL smaller, and back-fill some test.
Virtualize the handler interface so that it can be mocked.

Change-Id: Icbbc6b6789ba135b73c6fd1bbb90f5aae6ab7649
Reviewed-on: https://pdfium-review.googlesource.com/4250
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

1 files changed, 9 insertions, 10 deletions

diff --git a/core/fxcrt/xml/cfx_saxreaderhandler.h b/core/fxcrt/xml/cfx_saxreaderhandler.h
index bfedf03846..c5e1dc28b6 100644
--- a/core/fxcrt/xml/cfx_saxreaderhandler.h
+++ b/core/fxcrt/xml/cfx_saxreaderhandler.h
@@ -13,31 +13,30 @@
 
 class CFX_ChecksumContext;
 
-class CFX_SAXReaderHandler {
+class CFX_SAXReaderHandler : public CFX_SAXReader::HandlerIface {
  public:
   explicit CFX_SAXReaderHandler(CFX_ChecksumContext* pContext);
-  ~CFX_SAXReaderHandler();
+  ~CFX_SAXReaderHandler() override;
 
   CFX_SAXContext* OnTagEnter(const CFX_ByteStringC& bsTagName,
                              CFX_SAXItem::Type eType,
-                             uint32_t dwStartPos);
+                             uint32_t dwStartPos) override;
   void OnTagAttribute(CFX_SAXContext* pTag,
                       const CFX_ByteStringC& bsAttri,
-                      const CFX_ByteStringC& bsValue);
-  void OnTagBreak(CFX_SAXContext* pTag);
+                      const CFX_ByteStringC& bsValue) override;
+  void OnTagBreak(CFX_SAXContext* pTag) override;
   void OnTagData(CFX_SAXContext* pTag,
                  CFX_SAXItem::Type eType,
                  const CFX_ByteStringC& bsData,
-                 uint32_t dwStartPos);
-  void OnTagClose(CFX_SAXContext* pTag, uint32_t dwEndPos);
+                 uint32_t dwStartPos) override;
+  void OnTagClose(CFX_SAXContext* pTag, uint32_t dwEndPos) override;
   void OnTagEnd(CFX_SAXContext* pTag,
                 const CFX_ByteStringC& bsTagName,
-                uint32_t dwEndPos);
-
+                uint32_t dwEndPos) override;
   void OnTargetData(CFX_SAXContext* pTag,
                     CFX_SAXItem::Type eType,
                     const CFX_ByteStringC& bsData,
-                    uint32_t dwStartPos);
+                    uint32_t dwStartPos) override;
 
  private:
   void UpdateChecksum(bool bCheckSpace);