diff options
| author | dan sinclair <dsinclair@chromium.org> | 2018-04-13 00:22:55 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-13 00:22:55 +0000 |
| commit | 7afdad5ab7a1bd54ddf6f2a823be30d4b8e39567 (patch) | |
| tree | a594f1a42c742187d2312e0143f96548186ca33a /core/fxcrt/xml/cfx_xmlinstruction.h | |
| parent | c9f8d5af69e3b0bb6c8e58e74b61c016b2d099a1 (diff) | |
| download | pdfium-7afdad5ab7a1bd54ddf6f2a823be30d4b8e39567.tar.xz | |
Make CFX_XMLInstruction a subclass of CFX_XMLNode
The CFX_XMLInstruction handles the <?blah?> blocks at the top of an XML file.
It was inheriting from CFX_XMLAttributeNode in order to store the tag name. This
CL moves the tag name into CFX_XMLInstruction and subclasses from CFX_XMLNode.
Change-Id: I8f7ff0dde19ed43b46d095b0d45df4bf06875af5
Reviewed-on: https://pdfium-review.googlesource.com/30490
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'core/fxcrt/xml/cfx_xmlinstruction.h')
| -rw-r--r-- | core/fxcrt/xml/cfx_xmlinstruction.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/core/fxcrt/xml/cfx_xmlinstruction.h b/core/fxcrt/xml/cfx_xmlinstruction.h index 415a86a379..cbdf9e2538 100644 --- a/core/fxcrt/xml/cfx_xmlinstruction.h +++ b/core/fxcrt/xml/cfx_xmlinstruction.h @@ -13,7 +13,7 @@ #include "core/fxcrt/fx_string.h" #include "core/fxcrt/xml/cfx_xmlattributenode.h" -class CFX_XMLInstruction : public CFX_XMLAttributeNode { +class CFX_XMLInstruction : public CFX_XMLNode { public: explicit CFX_XMLInstruction(const WideString& wsTarget); ~CFX_XMLInstruction() override; @@ -23,11 +23,14 @@ class CFX_XMLInstruction : public CFX_XMLAttributeNode { std::unique_ptr<CFX_XMLNode> Clone() override; void Save(const RetainPtr<CFX_SeekableStreamProxy>& pXMLStream) override; + bool IsOriginalXFAVersion() const; + bool IsAcrobat() const; + const std::vector<WideString>& GetTargetData() const { return m_TargetData; } void AppendData(const WideString& wsData); - void RemoveData(int32_t index); private: + WideString name_; std::vector<WideString> m_TargetData; }; |