diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-10-26 22:52:48 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-26 22:52:48 +0000 |
| commit | 5883300439287ab46559231ce8aed11e92bbc97c (patch) | |
| tree | 2c3499da9df5a2c4e2fb9d13f99bde13b7bebb42 /core/fxge/dib/cfx_dibbase.h | |
| parent | 9590dee526c514d87dc1f47569d1136ffcf539ad (diff) | |
| download | pdfium-5883300439287ab46559231ce8aed11e92bbc97c.tar.xz | |
Replace int flags with struct FXDIB_ResampleOptions.
Using bit values in an int may not be reliable, since different parts of
the code can interpret the bits differently. e.g. FXDIB_DOWNSAMPLE and
RENDER_FORCE_DOWNSAMPLE are defined in different places, but can be used
interchangeably because they just happen to have the same value. It
works but is rather fragile.
Instead, use a struct of bools to explicitly define what different bits
mean. Remove FXDIB_DOWNSAMPLE and friends.
Change-Id: I9cf0c8f94d1ed27edf8dba22b0ab0ee67f2722cc
Reviewed-on: https://pdfium-review.googlesource.com/c/44650
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxge/dib/cfx_dibbase.h')
| -rw-r--r-- | core/fxge/dib/cfx_dibbase.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/fxge/dib/cfx_dibbase.h b/core/fxge/dib/cfx_dibbase.h index 81b0691563..23d65a3cda 100644 --- a/core/fxge/dib/cfx_dibbase.h +++ b/core/fxge/dib/cfx_dibbase.h @@ -80,7 +80,7 @@ class CFX_DIBBase : public Retainable { RetainPtr<CFX_DIBitmap> CloneConvert(FXDIB_Format format); RetainPtr<CFX_DIBitmap> StretchTo(int dest_width, int dest_height, - uint32_t flags, + const FXDIB_ResampleOptions& options, const FX_RECT* pClip); RetainPtr<CFX_DIBitmap> TransformTo(const CFX_Matrix& mtDest, int* left, |