diff options
author | Nicolas Pena <npm@chromium.org> | 2017-04-07 14:12:31 -0400 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2017-04-07 18:29:13 +0000 |
commit | 6a5c20cd08748da5969cbab756c3e8a6dd27bfbc (patch) | |
tree | 09a5d7e2666b166dc55e94a48270f17741d22b22 /core/fxge/dib/cfx_scanlinecompositor.h | |
parent | 1e8c39f18df6e597e079cce13d18d72631ef0fb9 (diff) | |
download | pdfium-6a5c20cd08748da5969cbab756c3e8a6dd27bfbc.tar.xz |
Remove the ICC transform where it is never initialized.
- All callers of CFX_DIBitmap methods use nullptr as the ICC Transform.
- The CFX_ScanlineCompositor is always initialized with a null ICC transform.
Many of its methods call TranslateScanline from the ICC module. This method
casts just uses ((CLcmsCmm*)pTransform)->m_hTransform, and this should not be
done when pTransform is nullptr.
Change-Id: I1b846d1f20699fa017cb9a276be3214eb8fabd4b
Reviewed-on: https://pdfium-review.googlesource.com/3931
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core/fxge/dib/cfx_scanlinecompositor.h')
-rw-r--r-- | core/fxge/dib/cfx_scanlinecompositor.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/core/fxge/dib/cfx_scanlinecompositor.h b/core/fxge/dib/cfx_scanlinecompositor.h index 2401bc5da8..a933a89b46 100644 --- a/core/fxge/dib/cfx_scanlinecompositor.h +++ b/core/fxge/dib/cfx_scanlinecompositor.h @@ -23,8 +23,7 @@ class CFX_ScanlineCompositor { int blend_type, bool bClip, bool bRgbByteOrder = false, - int alpha_flag = 0, - void* pIccTransform = nullptr); + int alpha_flag = 0); void CompositeRgbBitmapLine(uint8_t* dest_scan, const uint8_t* src_scan, @@ -65,7 +64,6 @@ class CFX_ScanlineCompositor { int m_MaskBlue; int m_MaskBlack; int m_BlendType; - void* m_pIccTransform; uint8_t* m_pCacheScanline; int m_CacheSize; bool m_bRgbByteOrder; |