diff options
author | Tom Sepez <tsepez@chromium.org> | 2015-08-18 09:20:29 -0700 |
---|---|---|
committer | Tom Sepez <tsepez@chromium.org> | 2015-08-18 09:20:29 -0700 |
commit | 85d5c4af4a9546970b34dd413c473d10fef8534b (patch) | |
tree | b993a0309a69b5c31c122971be04d062e3ae341c /core/include/fxcrt/fx_basic.h | |
parent | 57207efd5f17ec63e174061ea5415afb58516fce (diff) | |
download | pdfium-85d5c4af4a9546970b34dd413c473d10fef8534b.tar.xz |
FX_CMapDwordToDword considered harmful.
Lookups are log(n), but random insertions could result in n^2
behaviour. Replace with maps and sets.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1289703003 .
Diffstat (limited to 'core/include/fxcrt/fx_basic.h')
-rw-r--r-- | core/include/fxcrt/fx_basic.h | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h index 230d3db0f0..bc3d81200f 100644 --- a/core/include/fxcrt/fx_basic.h +++ b/core/include/fxcrt/fx_basic.h @@ -635,21 +635,6 @@ class CFX_MapPtrToPtr { CAssoc* GetAssocAt(void* key, FX_DWORD& hash) const; }; -class CFX_CMapDWordToDWord { - public: - FX_BOOL Lookup(FX_DWORD key, FX_DWORD& value) const; - - void SetAt(FX_DWORD key, FX_DWORD value); - - void EstimateSize(FX_DWORD size, FX_DWORD grow_by); - - FX_POSITION GetStartPosition() const; - - void GetNextAssoc(FX_POSITION& pos, FX_DWORD& key, FX_DWORD& value) const; - - protected: - CFX_BinaryBuf m_Buffer; -}; class CFX_CMapByteStringToPtr { public: CFX_CMapByteStringToPtr(); |