summaryrefslogtreecommitdiff
path: root/core/src/fpdfdoc/doc_bookmark.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2015-04-27 15:00:04 -0700
committerTom Sepez <tsepez@chromium.org>2015-04-27 15:00:04 -0700
commitee7412f5aef353e5c6f1a64d0e1708ed926869d9 (patch)
treebca46e77499d305e086dd71a335e551bcee59301 /core/src/fpdfdoc/doc_bookmark.cpp
parentbb93b0ba5b3c430d3b996e2c009d48feb17a44c3 (diff)
downloadpdfium-ee7412f5aef353e5c6f1a64d0e1708ed926869d9.tar.xz
Make CFX_WideString::LockBuffer() completely unused.
Then remove CFX_{Wide,Byte}String::LockBuffer(). Prelude to a vast simplification. There's an additional copy now in one place, so shoot me. BUG=pdfium:144 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1053613004
Diffstat (limited to 'core/src/fpdfdoc/doc_bookmark.cpp')
-rw-r--r--core/src/fpdfdoc/doc_bookmark.cpp10
1 files changed, 4 insertions, 6 deletions
diff --git a/core/src/fpdfdoc/doc_bookmark.cpp b/core/src/fpdfdoc/doc_bookmark.cpp
index 9814de61bf..88dcf21be1 100644
--- a/core/src/fpdfdoc/doc_bookmark.cpp
+++ b/core/src/fpdfdoc/doc_bookmark.cpp
@@ -55,15 +55,13 @@ CFX_WideString CPDF_Bookmark::GetTitle() const
return CFX_WideString();
}
CFX_WideString title = pString->GetUnicodeText();
- FX_LPWSTR buf = title.LockBuffer();
int len = title.GetLength();
+ FX_WCHAR buf[len];
for (int i = 0; i < len; i++) {
- if (buf[i] < 0x20) {
- buf[i] = 0x20;
- }
+ FX_WCHAR w = title[i];
+ buf[i] = w > 0x20 ? w : 0x20;
}
- title.ReleaseBuffer(len);
- return title;
+ return CFX_WideString(buf, len);
}
CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const
{