diff options
author | Tom Sepez <tsepez@chromium.org> | 2018-10-04 23:33:30 +0000 |
---|---|---|
committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-04 23:33:30 +0000 |
commit | 39cf6a765ae349242289ec3287eaf4d6c5fd57f8 (patch) | |
tree | ec387ee09ee40a2628a27f4215cd836749644bd3 /core | |
parent | 57353fb32972af2254070bfb2f662c8add8b2efb (diff) | |
download | pdfium-39cf6a765ae349242289ec3287eaf4d6c5fd57f8.tar.xz |
Change |virtual ~Foo(){}| to |virtual ~Foo()=default;|chromium/3571
Otherwise code coverage flags the empty body as unreachable.
Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767
Reviewed-on: https://pdfium-review.googlesource.com/c/43514
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'core')
-rw-r--r-- | core/fpdfapi/font/cfx_cttgsubtable.h | 2 | ||||
-rw-r--r-- | core/fpdfapi/parser/cpdf_document.h | 2 | ||||
-rw-r--r-- | core/fpdfdoc/ipdf_formnotify.h | 2 | ||||
-rw-r--r-- | core/fpdfdoc/ipvt_fontmap.h | 2 | ||||
-rw-r--r-- | core/fxcodec/codec/codec_module_iface.h | 4 | ||||
-rw-r--r-- | core/fxcrt/fileaccess_iface.h | 2 | ||||
-rw-r--r-- | core/fxcrt/locale_iface.h | 2 | ||||
-rw-r--r-- | core/fxcrt/pauseindicator_iface.h | 2 | ||||
-rw-r--r-- | core/fxge/dib/scanlinecomposer_iface.h | 2 |
9 files changed, 10 insertions, 10 deletions
diff --git a/core/fpdfapi/font/cfx_cttgsubtable.h b/core/fpdfapi/font/cfx_cttgsubtable.h index 6b23a8db27..54e16b4aed 100644 --- a/core/fpdfapi/font/cfx_cttgsubtable.h +++ b/core/fpdfapi/font/cfx_cttgsubtable.h @@ -60,7 +60,7 @@ class CFX_CTTGSUBTable { }; struct TCoverageFormatBase { - virtual ~TCoverageFormatBase() {} + virtual ~TCoverageFormatBase() = default; uint16_t CoverageFormat; }; diff --git a/core/fpdfapi/parser/cpdf_document.h b/core/fpdfapi/parser/cpdf_document.h index be3f30ce5d..d61129378e 100644 --- a/core/fpdfapi/parser/cpdf_document.h +++ b/core/fpdfapi/parser/cpdf_document.h @@ -47,7 +47,7 @@ class CPDF_Document : public Observable<CPDF_Document>, // Type from which the XFA extension can subclass itself. class Extension { public: - virtual ~Extension() {} + virtual ~Extension() = default; virtual CPDF_Document* GetPDFDoc() const = 0; virtual int GetPageCount() const = 0; virtual void DeletePage(int page_index) = 0; diff --git a/core/fpdfdoc/ipdf_formnotify.h b/core/fpdfdoc/ipdf_formnotify.h index 053ca12a41..7e11ecbd12 100644 --- a/core/fpdfdoc/ipdf_formnotify.h +++ b/core/fpdfdoc/ipdf_formnotify.h @@ -14,7 +14,7 @@ class CPDF_InterForm; class IPDF_FormNotify { public: - virtual ~IPDF_FormNotify() {} + virtual ~IPDF_FormNotify() = default; virtual bool BeforeValueChange(CPDF_FormField* pField, const WideString& csValue) = 0; diff --git a/core/fpdfdoc/ipvt_fontmap.h b/core/fpdfdoc/ipvt_fontmap.h index 31aa73b8a1..a27c0ac28a 100644 --- a/core/fpdfdoc/ipvt_fontmap.h +++ b/core/fpdfdoc/ipvt_fontmap.h @@ -15,7 +15,7 @@ class CPDF_Font; class IPVT_FontMap { public: - virtual ~IPVT_FontMap() {} + virtual ~IPVT_FontMap() = default; virtual CPDF_Font* GetPDFFont(int32_t nFontIndex) = 0; virtual ByteString GetPDFFontAlias(int32_t nFontIndex) = 0; diff --git a/core/fxcodec/codec/codec_module_iface.h b/core/fxcodec/codec/codec_module_iface.h index 08469726aa..e7faa892b2 100644 --- a/core/fxcodec/codec/codec_module_iface.h +++ b/core/fxcodec/codec/codec_module_iface.h @@ -16,10 +16,10 @@ class CodecModuleIface { public: class Context { public: - virtual ~Context() {} + virtual ~Context() = default; }; - virtual ~CodecModuleIface() {} + virtual ~CodecModuleIface() = default; // Returns the number of unprocessed bytes remaining in the input buffer. virtual FX_FILESIZE GetAvailInput(Context* pContext) const = 0; diff --git a/core/fxcrt/fileaccess_iface.h b/core/fxcrt/fileaccess_iface.h index 210080e438..fdabc7465e 100644 --- a/core/fxcrt/fileaccess_iface.h +++ b/core/fxcrt/fileaccess_iface.h @@ -16,7 +16,7 @@ class FileAccessIface { public: static std::unique_ptr<FileAccessIface> Create(); - virtual ~FileAccessIface() {} + virtual ~FileAccessIface() = default; virtual bool Open(const ByteStringView& fileName, uint32_t dwMode) = 0; virtual bool Open(const WideStringView& fileName, uint32_t dwMode) = 0; diff --git a/core/fxcrt/locale_iface.h b/core/fxcrt/locale_iface.h index 7e0ca6fd32..7ee18d93b8 100644 --- a/core/fxcrt/locale_iface.h +++ b/core/fxcrt/locale_iface.h @@ -46,7 +46,7 @@ enum FX_DATETIMETYPE { class LocaleIface { public: - virtual ~LocaleIface() {} + virtual ~LocaleIface() = default; virtual WideString GetName() const = 0; virtual WideString GetDecimalSymbol() const = 0; diff --git a/core/fxcrt/pauseindicator_iface.h b/core/fxcrt/pauseindicator_iface.h index c12b02e427..d5d856d94f 100644 --- a/core/fxcrt/pauseindicator_iface.h +++ b/core/fxcrt/pauseindicator_iface.h @@ -9,7 +9,7 @@ class PauseIndicatorIface { public: - virtual ~PauseIndicatorIface() {} + virtual ~PauseIndicatorIface() = default; virtual bool NeedToPauseNow() = 0; }; diff --git a/core/fxge/dib/scanlinecomposer_iface.h b/core/fxge/dib/scanlinecomposer_iface.h index 2a8fbbccdf..316736f63f 100644 --- a/core/fxge/dib/scanlinecomposer_iface.h +++ b/core/fxge/dib/scanlinecomposer_iface.h @@ -11,7 +11,7 @@ class ScanlineComposerIface { public: - virtual ~ScanlineComposerIface() {} + virtual ~ScanlineComposerIface() = default; virtual void ComposeScanline(int line, const uint8_t* scanline, |