diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-05 22:33:31 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-05 22:33:31 +0000 |
| commit | c22d671728605bc614dc84ec6a42a5647808b30d (patch) | |
| tree | ce4ec68b844414d1ce1f7275181795677b4ca87e /fpdfsdk/fpdfxfa | |
| parent | 7edcf2ce07e87022361a0e00fde27aad738c0621 (diff) | |
| download | pdfium-c22d671728605bc614dc84ec6a42a5647808b30d.tar.xz | |
Introduce IJS_Runtime::ScopedEventContext helper class.chromium/3451
This proves that m_EventContextArray is, in fact, a stack.
Tidy one function by using AutoRestorer while at it.
Change-Id: I319538b4eadcd9ce83319aa73861635dd5eb8c36
Reviewed-on: https://pdfium-review.googlesource.com/33970
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk/fpdfxfa')
| -rw-r--r-- | fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp index f9f5981efb..81e5fd08f4 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp +++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp @@ -994,10 +994,8 @@ bool CPDFXFA_DocEnvironment::SetPropertyInNonXFAGlobalObject( if (!pIJSRuntime) return false; - IJS_EventContext* pContext = pIJSRuntime->NewEventContext(); - bool bRet = pIJSRuntime->SetValueByNameInGlobalObject(szPropName, pValue); - pIJSRuntime->ReleaseEventContext(pContext); - return bRet; + IJS_Runtime::ScopedEventContext pContext(pIJSRuntime); + return pIJSRuntime->SetValueByNameInGlobalObject(szPropName, pValue); } bool CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject( @@ -1015,8 +1013,6 @@ bool CPDFXFA_DocEnvironment::GetPropertyFromNonXFAGlobalObject( if (!pIJSRuntime) return false; - IJS_EventContext* pContext = pIJSRuntime->NewEventContext(); - bool bRet = pIJSRuntime->GetValueByNameFromGlobalObject(szPropName, pValue); - pIJSRuntime->ReleaseEventContext(pContext); - return bRet; + IJS_Runtime::ScopedEventContext pContext(pIJSRuntime); + return pIJSRuntime->GetValueByNameFromGlobalObject(szPropName, pValue); } |