diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2017-10-25 13:30:31 -0400 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-10-25 18:40:45 +0000 |
| commit | 8f524d6ff9c5c5e07388438e58aca7dc39f43a1f (patch) | |
| tree | ec73d24ebdfb84e0c9a254a35912edc5ab54dae7 /fpdfsdk/javascript/console.h | |
| parent | 2474a3b2d9fe987dac58813771f1fa66427e124f (diff) | |
| download | pdfium-8f524d6ff9c5c5e07388438e58aca7dc39f43a1f.tar.xz | |
Refactor JS method parameters and return values.
This CL removes the out parameters from the JS methods and changes the
return from a |bool| to a |CJS_Return| value. The return value holds the
returned v8 object, error string and a status code.
Change-Id: I82488ff0d916475d7e3c8e51ed868639806181c9
Reviewed-on: https://pdfium-review.googlesource.com/16751
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/console.h')
| -rw-r--r-- | fpdfsdk/javascript/console.h | 24 |
1 files changed, 8 insertions, 16 deletions
diff --git a/fpdfsdk/javascript/console.h b/fpdfsdk/javascript/console.h index d7d1793dde..4ed66c1c05 100644 --- a/fpdfsdk/javascript/console.h +++ b/fpdfsdk/javascript/console.h @@ -17,22 +17,14 @@ class console : public CJS_EmbedObj { ~console() override; public: - bool clear(CJS_Runtime* pRuntime, - const std::vector<v8::Local<v8::Value>>& params, - CJS_Value& vRet, - WideString& sError); - bool hide(CJS_Runtime* pRuntime, - const std::vector<v8::Local<v8::Value>>& params, - CJS_Value& vRet, - WideString& sError); - bool println(CJS_Runtime* pRuntime, - const std::vector<v8::Local<v8::Value>>& params, - CJS_Value& vRet, - WideString& sError); - bool show(CJS_Runtime* pRuntime, - const std::vector<v8::Local<v8::Value>>& params, - CJS_Value& vRet, - WideString& sError); + CJS_Return clear(CJS_Runtime* pRuntime, + const std::vector<v8::Local<v8::Value>>& params); + CJS_Return hide(CJS_Runtime* pRuntime, + const std::vector<v8::Local<v8::Value>>& params); + CJS_Return println(CJS_Runtime* pRuntime, + const std::vector<v8::Local<v8::Value>>& params); + CJS_Return show(CJS_Runtime* pRuntime, + const std::vector<v8::Local<v8::Value>>& params); }; class CJS_Console : public CJS_Object { |