summaryrefslogtreecommitdiff
path: root/fpdfsdk/javascript/global.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2017-02-23 12:14:10 -0800
committerChromium commit bot <commit-bot@chromium.org>2017-02-23 20:43:24 +0000
commit77f6d0f8e64596992df4d2a046cc86f051574e02 (patch)
treeea57a90f435787775120dcb804b3c662db5c1b82 /fpdfsdk/javascript/global.cpp
parentb9c69ab7f1338684ffddbc1076052c546f1a95ad (diff)
downloadpdfium-77f6d0f8e64596992df4d2a046cc86f051574e02.tar.xz
Observe all formfill environment pointer in JS objects.
Preventitve measure to decouple JS object lifetimes from C++ objects. Change-Id: I964a52590fcd0bfc26ac6055a7daf8aa33d455f3 Reviewed-on: https://pdfium-review.googlesource.com/2828 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk/javascript/global.cpp')
-rw-r--r--fpdfsdk/javascript/global.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/fpdfsdk/javascript/global.cpp b/fpdfsdk/javascript/global.cpp
index 7dd8ab57be..a450606b1a 100644
--- a/fpdfsdk/javascript/global.cpp
+++ b/fpdfsdk/javascript/global.cpp
@@ -55,7 +55,7 @@ JSGlobalAlternate::~JSGlobalAlternate() {
}
void JSGlobalAlternate::Initial(CPDFSDK_FormFillEnvironment* pFormFillEnv) {
- m_pFormFillEnv = pFormFillEnv;
+ m_pFormFillEnv.Reset(pFormFillEnv);
m_pGlobalData = CJS_GlobalData::GetRetainedInstance(pFormFillEnv);
UpdateGlobalPersistentVariables();
}