diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-10-26 23:04:45 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-26 23:04:45 +0000 |
| commit | a9a582b226961d16af302f72a3354c4e99c013f3 (patch) | |
| tree | 782d42662f52f1ea8578c17d18015b250f98b782 /fpdfsdk/pwl/cpwl_wnd.h | |
| parent | 5883300439287ab46559231ce8aed11e92bbc97c (diff) | |
| download | pdfium-a9a582b226961d16af302f72a3354c4e99c013f3.tar.xz | |
Convert CPWL_Wnd::m_Children to vector of unique_ptr.
Still some lurking ownership issues.
Remove checks for null children, since the only way a child
gets into this vector is by AddChild(), and that does not
operate successfully on null arguments (tries to set the
parent in the child).
Change-Id: Ic0be6da05d7f7bb8bf1bd19ae6ae0580d2362dfc
Reviewed-on: https://pdfium-review.googlesource.com/c/44696
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fpdfsdk/pwl/cpwl_wnd.h')
| -rw-r--r-- | fpdfsdk/pwl/cpwl_wnd.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fpdfsdk/pwl/cpwl_wnd.h b/fpdfsdk/pwl/cpwl_wnd.h index 7f6bfec813..51e34a769d 100644 --- a/fpdfsdk/pwl/cpwl_wnd.h +++ b/fpdfsdk/pwl/cpwl_wnd.h @@ -306,7 +306,7 @@ class CPWL_Wnd : public CPWL_TimerHandler, public Observable<CPWL_Wnd> { CreateParams m_CreationParams; std::unique_ptr<PrivateData> m_pAttachedData; UnownedPtr<CPWL_Wnd> m_pParent; - std::vector<CPWL_Wnd*> m_Children; + std::vector<std::unique_ptr<CPWL_Wnd>> m_Children; UnownedPtr<CPWL_ScrollBar> m_pVScrollBar; CFX_FloatRect m_rcWindow; CFX_FloatRect m_rcClip; |