diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-10-04 23:33:30 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-04 23:33:30 +0000 |
| commit | 39cf6a765ae349242289ec3287eaf4d6c5fd57f8 (patch) | |
| tree | ec387ee09ee40a2628a27f4215cd836749644bd3 /fpdfsdk | |
| parent | 57353fb32972af2254070bfb2f662c8add8b2efb (diff) | |
| download | pdfium-39cf6a765ae349242289ec3287eaf4d6c5fd57f8.tar.xz | |
Change |virtual ~Foo(){}| to |virtual ~Foo()=default;|chromium/3571
Otherwise code coverage flags the empty body as unreachable.
Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767
Reviewed-on: https://pdfium-review.googlesource.com/c/43514
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fpdfsdk')
| -rw-r--r-- | fpdfsdk/ipdfsdk_annothandler.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/pwl/cpwl_edit.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/pwl/cpwl_edit_impl.h | 2 | ||||
| -rw-r--r-- | fpdfsdk/pwl/cpwl_wnd.h | 4 |
4 files changed, 5 insertions, 5 deletions
diff --git a/fpdfsdk/ipdfsdk_annothandler.h b/fpdfsdk/ipdfsdk_annothandler.h index 1476089253..11c43ecf0b 100644 --- a/fpdfsdk/ipdfsdk_annothandler.h +++ b/fpdfsdk/ipdfsdk_annothandler.h @@ -21,7 +21,7 @@ class CXFA_FFWidget; class IPDFSDK_AnnotHandler { public: - virtual ~IPDFSDK_AnnotHandler() {} + virtual ~IPDFSDK_AnnotHandler() = default; virtual bool CanAnswer(CPDFSDK_Annot* pAnnot) = 0; virtual CPDFSDK_Annot* NewAnnot(CPDF_Annot* pAnnot, diff --git a/fpdfsdk/pwl/cpwl_edit.h b/fpdfsdk/pwl/cpwl_edit.h index 849436a3e3..d890834aac 100644 --- a/fpdfsdk/pwl/cpwl_edit.h +++ b/fpdfsdk/pwl/cpwl_edit.h @@ -15,7 +15,7 @@ class IPWL_Filler_Notify { public: - virtual ~IPWL_Filler_Notify() {} + virtual ~IPWL_Filler_Notify() = default; // Must write to |bBottom| and |fPopupRet|. virtual void QueryWherePopup(CPWL_Wnd::PrivateData* pAttached, diff --git a/fpdfsdk/pwl/cpwl_edit_impl.h b/fpdfsdk/pwl/cpwl_edit_impl.h index 7f14ade66a..047286322f 100644 --- a/fpdfsdk/pwl/cpwl_edit_impl.h +++ b/fpdfsdk/pwl/cpwl_edit_impl.h @@ -96,7 +96,7 @@ class CPWL_EditImpl_Undo { class IFX_Edit_UndoItem { public: - virtual ~IFX_Edit_UndoItem() {} + virtual ~IFX_Edit_UndoItem() = default; virtual void Undo() = 0; virtual void Redo() = 0; diff --git a/fpdfsdk/pwl/cpwl_wnd.h b/fpdfsdk/pwl/cpwl_wnd.h index 1ed239ed85..cc6662be30 100644 --- a/fpdfsdk/pwl/cpwl_wnd.h +++ b/fpdfsdk/pwl/cpwl_wnd.h @@ -106,7 +106,7 @@ class CPWL_Wnd : public CPWL_TimerHandler, public Observable<CPWL_Wnd> { class ProviderIface : public Observable<ProviderIface> { public: - virtual ~ProviderIface() {} + virtual ~ProviderIface() = default; // get a matrix which map user space to CWnd client space virtual CFX_Matrix GetWindowMatrix(PrivateData* pAttached) = 0; @@ -114,7 +114,7 @@ class CPWL_Wnd : public CPWL_TimerHandler, public Observable<CPWL_Wnd> { class FocusHandlerIface { public: - virtual ~FocusHandlerIface() {} + virtual ~FocusHandlerIface() = default; virtual void OnSetFocus(CPWL_Edit* pEdit) = 0; }; |