Make CBC_CodeBase::SetTextLocation() not virtual.

Make CBC_Writer::SetTextLocation() virtual instead.

Change-Id: I9ac06affe35f3c7bebc2f5ff0917e7146cfe89cc
Reviewed-on: https://pdfium-review.googlesource.com/42601
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>

1 files changed, 18 insertions, 15 deletions

diff --git a/fxbarcode/BC_Writer.cpp b/fxbarcode/BC_Writer.cpp
index 5c8e0cf3b7..8d639d3f01 100644
--- a/fxbarcode/BC_Writer.cpp
+++ b/fxbarcode/BC_Writer.cpp
@@ -6,50 +6,53 @@
 
 #include "fxbarcode/BC_Writer.h"
 
-CBC_Writer::CBC_Writer() {
-  m_CharEncoding = 0;
-  m_ModuleHeight = 1;
-  m_ModuleWidth = 1;
-  m_Height = 320;
-  m_Width = 640;
-  m_colorSpace = FXDIB_Argb;
-  m_barColor = 0xff000000;
-  m_backgroundColor = 0xffffffff;
-}
-CBC_Writer::~CBC_Writer() {}
+CBC_Writer::CBC_Writer() = default;
+
+CBC_Writer::~CBC_Writer() = default;
+
 bool CBC_Writer::SetCharEncoding(int32_t encoding) {
   m_CharEncoding = encoding;
   return true;
 }
+
 bool CBC_Writer::SetModuleHeight(int32_t moduleHeight) {
-  if (moduleHeight > 10 || moduleHeight < 1) {
+  if (moduleHeight > 10 || moduleHeight < 1)
     return false;
-  }
+
   m_ModuleHeight = moduleHeight;
   return true;
 }
+
 bool CBC_Writer::SetModuleWidth(int32_t moduleWidth) {
-  if (moduleWidth > 10 || moduleWidth < 1) {
+  if (moduleWidth > 10 || moduleWidth < 1)
     return false;
-  }
+
   m_ModuleWidth = moduleWidth;
   return true;
 }
+
 bool CBC_Writer::SetHeight(int32_t height) {
   m_Height = height;
   return true;
 }
+
 bool CBC_Writer::SetWidth(int32_t width) {
   m_Width = width;
   return true;
 }
+
 void CBC_Writer::SetBackgroundColor(FX_ARGB backgroundColor) {
   m_backgroundColor = backgroundColor;
 }
+
 void CBC_Writer::SetBarcodeColor(FX_ARGB foregroundColor) {
   m_barColor = foregroundColor;
 }
 
+bool CBC_Writer::SetTextLocation(BC_TEXT_LOC location) {
+  return false;
+}
+
 RetainPtr<CFX_DIBitmap> CBC_Writer::CreateDIBitmap(int32_t width,
                                                    int32_t height) {
   auto pDIBitmap = pdfium::MakeRetain<CFX_DIBitmap>();