diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-04 19:44:37 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-04 19:44:37 +0000 |
| commit | 36aae4fc09a353e01738bf0bbc302a21ba21ed07 (patch) | |
| tree | 2d9d1cbe2f7c8eeed7aff9fc63a8f8300a25d6b7 /fxjs/cfxjs_engine_unittest.cpp | |
| parent | 9d3fb11a985a8f2aefbf361c0030c7bce2248b8e (diff) | |
| download | pdfium-36aae4fc09a353e01738bf0bbc302a21ba21ed07.tar.xz | |
Make CJS_Objects track CJS_Runtime (and hence the document itself)
Precursor to removing some more v8::Context slot dependency.
There's a cost to maintaining the set of observers, but since these
objects are tied to V8 lifetimes, not C++ lifetimes, we want to be
very wary of the document going away unexpectedly.
Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12
Reviewed-on: https://pdfium-review.googlesource.com/33471
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/cfxjs_engine_unittest.cpp')
| -rw-r--r-- | fxjs/cfxjs_engine_unittest.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/cfxjs_engine_unittest.cpp b/fxjs/cfxjs_engine_unittest.cpp index 5b93072935..64cd3a3e1e 100644 --- a/fxjs/cfxjs_engine_unittest.cpp +++ b/fxjs/cfxjs_engine_unittest.cpp @@ -43,7 +43,7 @@ TEST_F(FXJSEngineUnitTest, GC) { engine()->DefineObj("perm", FXJSOBJTYPE_DYNAMIC, [](CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { pEngine->SetObjectPrivate( - obj, pdfium::MakeUnique<CJS_Object>(obj)); + obj, pdfium::MakeUnique<CJS_Object>(obj, nullptr)); perm_created = true; }, [](v8::Local<v8::Object> obj) { @@ -55,7 +55,7 @@ TEST_F(FXJSEngineUnitTest, GC) { engine()->DefineObj("temp", FXJSOBJTYPE_DYNAMIC, [](CFXJS_Engine* pEngine, v8::Local<v8::Object> obj) { pEngine->SetObjectPrivate( - obj, pdfium::MakeUnique<CJS_Object>(obj)); + obj, pdfium::MakeUnique<CJS_Object>(obj, nullptr)); temp_created = true; }, [](v8::Local<v8::Object> obj) { |