summaryrefslogtreecommitdiff
path: root/fxjs/cfxjs_engine_unittest.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-08-14 23:40:10 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-08-14 23:40:10 +0000
commit55ccb526913debb3269a33792bbd61b05656ec46 (patch)
treea98152baf9d4a5dcf1c76ecaf53cbae35720d2b8 /fxjs/cfxjs_engine_unittest.cpp
parent48d62c3a5f57eb3397a335bea4a5a30de2fcb955 (diff)
downloadpdfium-55ccb526913debb3269a33792bbd61b05656ec46.tar.xz
Remove optional argument from NewFXJSBoundObject().
Additionally, we have a pre-existing enum type that is more meaningful than just a boolean. Change-Id: Ie6ad13a3c9b22e34dedf7a5a9b5b9cc2a49b1f03 Reviewed-on: https://pdfium-review.googlesource.com/40190 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjs_engine_unittest.cpp')
-rw-r--r--fxjs/cfxjs_engine_unittest.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/fxjs/cfxjs_engine_unittest.cpp b/fxjs/cfxjs_engine_unittest.cpp
index 64cd3a3e1e..0902fdbb0e 100644
--- a/fxjs/cfxjs_engine_unittest.cpp
+++ b/fxjs/cfxjs_engine_unittest.cpp
@@ -66,14 +66,16 @@ TEST_F(FXJSEngineUnitTest, GC) {
engine()->InitializeEngine();
v8::Context::Scope context_scope(engine()->GetV8Context());
- v8::Local<v8::Object> perm = engine()->NewFXJSBoundObject(0, false);
+ v8::Local<v8::Object> perm =
+ engine()->NewFXJSBoundObject(0, FXJSOBJTYPE_DYNAMIC);
EXPECT_FALSE(perm.IsEmpty());
EXPECT_TRUE(perm_created);
EXPECT_FALSE(perm_destroyed);
{
v8::HandleScope inner_handle_scope(isolate());
- v8::Local<v8::Object> temp = engine()->NewFXJSBoundObject(1, false);
+ v8::Local<v8::Object> temp =
+ engine()->NewFXJSBoundObject(1, FXJSOBJTYPE_DYNAMIC);
EXPECT_FALSE(temp.IsEmpty());
EXPECT_TRUE(temp_created);
EXPECT_FALSE(temp_destroyed);