summaryrefslogtreecommitdiff
path: root/fxjs/cfxjse_context.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-07-24 16:29:25 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-07-24 16:29:25 +0000
commitc9f1234b1982eb7ec8a5254195574e88bee54703 (patch)
treecdc8831de3fae8d571646c29bad3da80cd63799c /fxjs/cfxjse_context.cpp
parentaa50728980036f07fda232cea974fd80c89b7cb7 (diff)
downloadpdfium-c9f1234b1982eb7ec8a5254195574e88bee54703.tar.xz
Remove lpClass argument from FXJSE_RetrieveObjectBinding()
In turn, it too is always nullptr. This shows that the V8 side check for hasInstance() was never being applied. We will augment this with C++ side checks down the road, since we don't want to trust V8 anyways. Change-Id: Iee38f32af9561783dbf253d798bd975029f3a4a2 Reviewed-on: https://pdfium-review.googlesource.com/38594 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_context.cpp')
-rw-r--r--fxjs/cfxjse_context.cpp11
1 files changed, 2 insertions, 9 deletions
diff --git a/fxjs/cfxjse_context.cpp b/fxjs/cfxjse_context.cpp
index 32fdd60cda..6c5a95f966 100644
--- a/fxjs/cfxjse_context.cpp
+++ b/fxjs/cfxjse_context.cpp
@@ -120,8 +120,8 @@ void FXJSE_UpdateObjectBinding(v8::Local<v8::Object>& hObject,
hObject->SetAlignedPointerInInternalField(1, lpNewBinding);
}
-CFXJSE_HostObject* FXJSE_RetrieveObjectBinding(v8::Local<v8::Object> hJSObject,
- CFXJSE_Class* lpClass) {
+CFXJSE_HostObject* FXJSE_RetrieveObjectBinding(
+ v8::Local<v8::Object> hJSObject) {
ASSERT(!hJSObject.IsEmpty());
if (!hJSObject->IsObject())
return nullptr;
@@ -140,13 +140,6 @@ CFXJSE_HostObject* FXJSE_RetrieveObjectBinding(v8::Local<v8::Object> hJSObject,
if (hObject->GetAlignedPointerFromInternalField(0) != g_FXJSEHostObjectTag)
return nullptr;
- if (lpClass) {
- v8::Local<v8::FunctionTemplate> hClass =
- v8::Local<v8::FunctionTemplate>::New(
- lpClass->GetContext()->GetIsolate(), lpClass->GetTemplate());
- if (!hClass->HasInstance(hObject))
- return nullptr;
- }
return static_cast<CFXJSE_HostObject*>(
hObject->GetAlignedPointerFromInternalField(1));
}