diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-08-17 16:44:50 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-08-17 16:44:50 +0000 |
| commit | 20736f7f5884cf1e2827543c92b6e47f8282aeaf (patch) | |
| tree | 9a0f3cbd9262d1676f70ab02c3fa5b4e0acaa03a /fxjs/cfxjse_engine.cpp | |
| parent | 21068062a038db72b5ee40512fe638acbdd17c3d (diff) | |
| download | pdfium-20736f7f5884cf1e2827543c92b6e47f8282aeaf.tar.xz | |
Introduce safer CJS_Return::Success() and Failure().
Avoid the possibility of ever re-introducing the issue noticed
last week.
Remove some redundant JSGetStringFromID() calls.
Change-Id: I56687c2191bd72e378f747083f34080e50cbe490
Reviewed-on: https://pdfium-review.googlesource.com/40490
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_engine.cpp')
| -rw-r--r-- | fxjs/cfxjse_engine.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fxjs/cfxjse_engine.cpp b/fxjs/cfxjse_engine.cpp index 78b0644976..7a4865ba21 100644 --- a/fxjs/cfxjse_engine.cpp +++ b/fxjs/cfxjse_engine.cpp @@ -442,7 +442,7 @@ CJS_Return CFXJSE_Engine::NormalMethodCall( const WideString& functionName) { CXFA_Object* pObject = ToObject(info); if (!pObject) - return CJS_Return(L"no Holder() present."); + return CJS_Return::Failure(L"no Holder() present."); CFXJSE_Engine* lpScriptContext = pObject->GetDocument()->GetScriptContext(); pObject = lpScriptContext->GetVariablesThis(pObject, false); |