summaryrefslogtreecommitdiff
path: root/fxjs/cfxjse_runtimedata.h
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-07-16 21:35:06 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-07-16 21:35:06 +0000
commit98b356a36bc9291a4f222d092afeeea0d5b5f379 (patch)
tree71fbda3964df30ef354afd36e3a9aba32978f762 /fxjs/cfxjse_runtimedata.h
parent31781107f6bda92e732fed805f62e8512bc78149 (diff)
downloadpdfium-98b356a36bc9291a4f222d092afeeea0d5b5f379.tar.xz
Use UnownedPtr<> to v8::Isolates.
Isolates are long-lived, but this may catch a few things. Introduce CFX_V8IsolateDeleter for unique_ptr<v8::Isolate> usage. Fix Dispose()/SetIsolate(nullptr) ordering in cjs_runtime.cpp Remove one unused isolate member. Flip protected -> private in one place. Change-Id: I26cdd120f799192e93b0d9d04dcde8f348dc21f3 Reviewed-on: https://pdfium-review.googlesource.com/37931 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cfxjse_runtimedata.h')
-rw-r--r--fxjs/cfxjse_runtimedata.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/fxjs/cfxjse_runtimedata.h b/fxjs/cfxjse_runtimedata.h
index 292fe26ae3..fd4cbd7c4e 100644
--- a/fxjs/cfxjse_runtimedata.h
+++ b/fxjs/cfxjse_runtimedata.h
@@ -9,6 +9,7 @@
#include <memory>
+#include "core/fxcrt/unowned_ptr.h"
#include "v8/include/v8.h"
class CFXJSE_RuntimeList;
@@ -19,12 +20,11 @@ class CFXJSE_RuntimeData {
static CFXJSE_RuntimeData* Get(v8::Isolate* pIsolate);
- v8::Isolate* m_pIsolate;
v8::Global<v8::FunctionTemplate> m_hRootContextGlobalTemplate;
v8::Global<v8::Context> m_hRootContext;
protected:
- explicit CFXJSE_RuntimeData(v8::Isolate* pIsolate);
+ CFXJSE_RuntimeData();
static std::unique_ptr<CFXJSE_RuntimeData> Create(v8::Isolate* pIsolate);