summaryrefslogtreecommitdiff
path: root/fxjs/cjs_app.cpp
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2018-02-05 18:52:09 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-02-05 18:52:09 +0000
commit57e097750846bf3ffc3e4e2ef9e78be8a82c69de (patch)
tree080a0d644b816cc6d2cb0b00f4c9629020894316 /fxjs/cjs_app.cpp
parent13c4d1b46641fb3041800cad3032e7e60026e3f4 (diff)
downloadpdfium-57e097750846bf3ffc3e4e2ef9e78be8a82c69de.tar.xz
Use unique pointer in CFXJS_PerObjectData.
Also use the actual type information, not void* and remove casts. Template function not required to wrap virtual dtors. Change-Id: I9397cae136c3c395a368a1ef0ce8162d9b586076 Reviewed-on: https://pdfium-review.googlesource.com/25290 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cjs_app.cpp')
-rw-r--r--fxjs/cjs_app.cpp8
1 files changed, 3 insertions, 5 deletions
diff --git a/fxjs/cjs_app.cpp b/fxjs/cjs_app.cpp
index 32cac22153..7d16cbaaa2 100644
--- a/fxjs/cjs_app.cpp
+++ b/fxjs/cjs_app.cpp
@@ -77,9 +77,8 @@ int CJS_App::ObjDefnID = -1;
// static
void CJS_App::DefineJSObjects(CFXJS_Engine* pEngine) {
- ObjDefnID =
- pEngine->DefineObj("app", FXJSOBJTYPE_STATIC, JSConstructor<CJS_App, app>,
- JSDestructor<CJS_App>);
+ ObjDefnID = pEngine->DefineObj("app", FXJSOBJTYPE_STATIC,
+ JSConstructor<CJS_App, app>, JSDestructor);
DefineProps(pEngine, ObjDefnID, PropertySpecs, FX_ArraySize(PropertySpecs));
DefineMethods(pEngine, ObjDefnID, MethodSpecs, FX_ArraySize(MethodSpecs));
}
@@ -376,8 +375,7 @@ void app::ClearTimerCommon(CJS_Runtime* pRuntime, v8::Local<v8::Value> param) {
if (CFXJS_Engine::GetObjDefnID(pObj) != CJS_TimerObj::GetObjDefnID())
return;
- CJS_Object* pJSObj =
- static_cast<CJS_Object*>(pRuntime->GetObjectPrivate(pObj));
+ CJS_Object* pJSObj = pRuntime->GetObjectPrivate(pObj);
if (!pJSObj)
return;