diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-02-05 18:52:09 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-05 18:52:09 +0000 |
| commit | 57e097750846bf3ffc3e4e2ef9e78be8a82c69de (patch) | |
| tree | 080a0d644b816cc6d2cb0b00f4c9629020894316 /fxjs/cjs_global.cpp | |
| parent | 13c4d1b46641fb3041800cad3032e7e60026e3f4 (diff) | |
| download | pdfium-57e097750846bf3ffc3e4e2ef9e78be8a82c69de.tar.xz | |
Use unique pointer in CFXJS_PerObjectData.
Also use the actual type information, not void* and remove casts.
Template function not required to wrap virtual dtors.
Change-Id: I9397cae136c3c395a368a1ef0ce8162d9b586076
Reviewed-on: https://pdfium-review.googlesource.com/25290
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/cjs_global.cpp')
| -rw-r--r-- | fxjs/cjs_global.cpp | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp index 3fc4bf0f0f..0326516f1b 100644 --- a/fxjs/cjs_global.cpp +++ b/fxjs/cjs_global.cpp @@ -37,8 +37,7 @@ void JSSpecialPropQuery(const char*, if (!pRuntime) return; - CJS_Object* pJSObj = - static_cast<CJS_Object*>(pRuntime->GetObjectPrivate(info.Holder())); + CJS_Object* pJSObj = pRuntime->GetObjectPrivate(info.Holder()); if (!pJSObj) return; @@ -57,8 +56,7 @@ void JSSpecialPropGet(const char* class_name, if (!pRuntime) return; - CJS_Object* pJSObj = - static_cast<CJS_Object*>(pRuntime->GetObjectPrivate(info.Holder())); + CJS_Object* pJSObj = pRuntime->GetObjectPrivate(info.Holder()); if (!pJSObj) return; @@ -85,8 +83,7 @@ void JSSpecialPropPut(const char* class_name, if (!pRuntime) return; - CJS_Object* pJSObj = - static_cast<CJS_Object*>(pRuntime->GetObjectPrivate(info.Holder())); + CJS_Object* pJSObj = pRuntime->GetObjectPrivate(info.Holder()); if (!pJSObj) return; @@ -108,8 +105,7 @@ void JSSpecialPropDel(const char* class_name, if (!pRuntime) return; - CJS_Object* pJSObj = - static_cast<CJS_Object*>(pRuntime->GetObjectPrivate(info.Holder())); + CJS_Object* pJSObj = pRuntime->GetObjectPrivate(info.Holder()); if (!pJSObj) return; @@ -227,7 +223,7 @@ void CJS_Global::DefineAllProperties(CFXJS_Engine* pEngine) { void CJS_Global::DefineJSObjects(CFXJS_Engine* pEngine) { ObjDefnID = pEngine->DefineObj("global", FXJSOBJTYPE_STATIC, JSConstructor<CJS_Global, JSGlobalAlternate>, - JSDestructor<CJS_Global>); + JSDestructor); DefineMethods(pEngine, ObjDefnID, MethodSpecs, FX_ArraySize(MethodSpecs)); DefineAllProperties(pEngine); } |