Convert JS resource into enum classchromium/3254

This CL converts the #defines into an enum class.

Change-Id: I895e29e1d46a7a82d7be896f5776eb00d28559f5
Reviewed-on: https://pdfium-review.googlesource.com/17091
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

1 files changed, 23 insertions, 21 deletions

diff --git a/fxjs/js_resources.h b/fxjs/js_resources.h
index 9f655487ba..728ec22126 100644
--- a/fxjs/js_resources.h
+++ b/fxjs/js_resources.h
@@ -9,28 +9,30 @@
 
 #include "core/fxcrt/widestring.h"
 
-#define IDS_STRING_JSALERT 25613
-#define IDS_STRING_JSPARAMERROR 25614
-#define IDS_STRING_JSAFNUMBER_KEYSTROKE 25615
-#define IDS_STRING_JSPARAM_TOOLONG 25617
-#define IDS_STRING_JSPARSEDATE 25618
-#define IDS_STRING_JSRANGE1 25619
-#define IDS_STRING_JSRANGE2 25620
-#define IDS_STRING_JSRANGE3 25621
-#define IDS_STRING_JSNOTSUPPORT 25627
-#define IDS_STRING_JSBUSY 25628
-#define IDS_STRING_JSEVENT 25629
-#define IDS_STRING_RUN 25630
-#define IDS_STRING_JSPRINT1 25632
-#define IDS_STRING_JSPRINT2 25633
-#define IDS_STRING_JSNOGLOBAL 25635
-#define IDS_STRING_JSREADONLY 25636
-#define IDS_STRING_JSTYPEERROR 25637
-#define IDS_STRING_JSVALUEERROR 25638
-#define IDS_STRING_JSNOPERMISSION 25639
-#define IDS_STRING_JSBADOBJECT 25640
+enum class JSMessage {
+  kRunSuccess = 0,
+  kAlert,
+  kParamError,
+  kInvalidInputError,
+  kParamTooLongError,
+  kParseDateError,
+  kRangeBetweenError,
+  kRangeGreaterError,
+  kRangeLessError,
+  kNotSupportedError,
+  kBusyError,
+  kDuplicateEventError,
+  kSecondParamNotDateError,
+  kSecondParamInvalidDateError,
+  kGlobalNotFoundError,
+  kReadOnlyError,
+  kTypeError,
+  kValueError,
+  kPermissionError,
+  kBadObjectError
+};
 
-WideString JSGetStringFromID(uint32_t id);
+WideString JSGetStringFromID(JSMessage msg);
 WideString JSFormatErrorString(const char* class_name,
                                const char* property_name,
                                const WideString& details);