summaryrefslogtreecommitdiff
path: root/fxjs
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-10-18 19:15:47 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-10-18 19:15:47 +0000
commit378ec548964d57311faab4627e570566bd20aaa0 (patch)
tree4b34aed8a671fb573363aab7f571de38e8e62237 /fxjs
parentd66f39a421233931d4da0832c72aae965ad909ee (diff)
downloadpdfium-378ec548964d57311faab4627e570566bd20aaa0.tar.xz
Remove a few V8 includes from header files.
Change-Id: I087c4e712aa87f99ada4ef515f5b361037a5dae0 Reviewed-on: https://pdfium-review.googlesource.com/c/44257 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'fxjs')
-rw-r--r--fxjs/cfx_v8.h1
-rw-r--r--fxjs/cfxjs_engine.cpp5
-rw-r--r--fxjs/cfxjs_engine.h5
3 files changed, 6 insertions, 5 deletions
diff --git a/fxjs/cfx_v8.h b/fxjs/cfx_v8.h
index 3ebabdefec..70d365517a 100644
--- a/fxjs/cfx_v8.h
+++ b/fxjs/cfx_v8.h
@@ -11,7 +11,6 @@
#include "core/fxcrt/fx_string.h"
#include "core/fxcrt/unowned_ptr.h"
-#include "v8/include/v8-util.h"
#include "v8/include/v8.h"
class CFX_V8 {
diff --git a/fxjs/cfxjs_engine.cpp b/fxjs/cfxjs_engine.cpp
index f1dd45016e..c993a7dafa 100644
--- a/fxjs/cfxjs_engine.cpp
+++ b/fxjs/cfxjs_engine.cpp
@@ -15,6 +15,7 @@
#include "fxjs/cjs_object.h"
#include "third_party/base/ptr_util.h"
#include "third_party/base/stl_util.h"
+#include "v8/include/v8-util.h"
class CFXJS_PerObjectData;
@@ -590,6 +591,10 @@ void CFXJS_Engine::Error(const WideString& message) {
GetIsolate()->ThrowException(NewString(message.AsStringView()));
}
+v8::Local<v8::Context> CFXJS_Engine::GetV8Context() {
+ return v8::Local<v8::Context>::New(GetIsolate(), m_V8Context);
+}
+
// static
CJS_Object* CFXJS_Engine::GetObjectPrivate(v8::Local<v8::Object> pObj) {
auto* pData = CFXJS_PerObjectData::GetFromObject(pObj);
diff --git a/fxjs/cfxjs_engine.h b/fxjs/cfxjs_engine.h
index 0ee4fe5bf4..8c6c69c9be 100644
--- a/fxjs/cfxjs_engine.h
+++ b/fxjs/cfxjs_engine.h
@@ -22,7 +22,6 @@
#include "core/fxcrt/fx_string.h"
#include "fxjs/cfx_v8.h"
#include "fxjs/ijs_runtime.h"
-#include "v8/include/v8-util.h"
#include "v8/include/v8.h"
#ifdef PDF_ENABLE_XFA
@@ -128,9 +127,7 @@ class CFXJS_Engine : public CFX_V8 {
v8::Local<v8::Object> NewFXJSBoundObject(int nObjDefnID, FXJSOBJTYPE type);
void Error(const WideString& message);
- v8::Local<v8::Context> GetV8Context() {
- return v8::Local<v8::Context>::New(GetIsolate(), m_V8Context);
- }
+ v8::Local<v8::Context> GetV8Context();
v8::Local<v8::Array> GetConstArray(const WideString& name);
void SetConstArray(const WideString& name, v8::Local<v8::Array> array);