summaryrefslogtreecommitdiff
path: root/fxjs
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-10-19 18:06:52 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-10-19 18:06:52 +0000
commitaf3d6cc8910fbddc7518f9d54f4c4ad0dd25ed40 (patch)
tree08040e04003114de096421a3fa687cd6ce58ebf3 /fxjs
parentcdebbeb8cca214ffb518a9cdc7f51ac376608b8c (diff)
downloadpdfium-af3d6cc8910fbddc7518f9d54f4c4ad0dd25ed40.tar.xz
Roll v8/ 604c50c84..626844157 (516 commits)chromium/3588chromium/3587chromium/3586
https://chromium.googlesource.com/v8/v8.git/+log/604c50c84e67..626844157660 Version 7.1.314 Update a few callers to avoid deprecated V8 APIs. Created with: roll-dep v8 Change-Id: Ifabcae4956364cf1d02d4c2fe6074806fadc7ee3 Reviewed-on: https://pdfium-review.googlesource.com/c/43595 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs')
-rw-r--r--fxjs/cfx_v8.cpp6
-rw-r--r--fxjs/cfxjse_arguments.cpp4
-rw-r--r--fxjs/cfxjse_value.cpp3
3 files changed, 3 insertions, 10 deletions
diff --git a/fxjs/cfx_v8.cpp b/fxjs/cfx_v8.cpp
index 73d95ae9b4..bd0e5eb62a 100644
--- a/fxjs/cfx_v8.cpp
+++ b/fxjs/cfx_v8.cpp
@@ -150,11 +150,7 @@ int CFX_V8::ToInt32(v8::Local<v8::Value> pValue) {
bool CFX_V8::ToBoolean(v8::Local<v8::Value> pValue) {
if (pValue.IsEmpty())
return false;
- v8::Local<v8::Context> context = m_pIsolate->GetCurrentContext();
- v8::MaybeLocal<v8::Boolean> maybe_boolean = pValue->ToBoolean(context);
- if (maybe_boolean.IsEmpty())
- return false;
- return maybe_boolean.ToLocalChecked()->Value();
+ return pValue->BooleanValue(m_pIsolate.Get());
}
double CFX_V8::ToDouble(v8::Local<v8::Value> pValue) {
diff --git a/fxjs/cfxjse_arguments.cpp b/fxjs/cfxjse_arguments.cpp
index 174fd3c2c7..e18e3e3d96 100644
--- a/fxjs/cfxjse_arguments.cpp
+++ b/fxjs/cfxjse_arguments.cpp
@@ -28,9 +28,7 @@ std::unique_ptr<CFXJSE_Value> CFXJSE_Arguments::GetValue(int32_t index) const {
}
bool CFXJSE_Arguments::GetBoolean(int32_t index) const {
- return (*m_pInfo)[index]
- ->BooleanValue(m_pInfo->GetIsolate()->GetCurrentContext())
- .FromMaybe(false);
+ return (*m_pInfo)[index]->BooleanValue(m_pInfo->GetIsolate());
}
int32_t CFXJSE_Arguments::GetInt32(int32_t index) const {
diff --git a/fxjs/cfxjse_value.cpp b/fxjs/cfxjse_value.cpp
index 8bc243e097..a84b571223 100644
--- a/fxjs/cfxjse_value.cpp
+++ b/fxjs/cfxjse_value.cpp
@@ -406,8 +406,7 @@ bool CFXJSE_Value::ToBoolean() const {
CFXJSE_ScopeUtil_IsolateHandleRootContext scope(GetIsolate());
v8::Local<v8::Value> hValue =
v8::Local<v8::Value>::New(GetIsolate(), m_hValue);
- return hValue->BooleanValue(GetIsolate()->GetCurrentContext())
- .FromMaybe(false);
+ return hValue->BooleanValue(GetIsolate());
}
float CFXJSE_Value::ToFloat() const {