diff options
| author | Lei Zhang <thestig@chromium.org> | 2017-12-19 18:50:15 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2017-12-19 18:50:15 +0000 |
| commit | 9ccf08746e57a03fd9afc187cb3e23404cdc88bb (patch) | |
| tree | cbaf0c99d396623cda57c1b4a8e4c19f887880ab /public | |
| parent | 8ab9f80a944c16000f6a6f15366dd3704d315401 (diff) | |
| download | pdfium-9ccf08746e57a03fd9afc187cb3e23404cdc88bb.tar.xz | |
Add missing fpdfview_c_api_test.c entries.
Add a presubmit check to prevent future missing entries. Also fix an
erroneous header entry.
Change-Id: I8aeafd820de984f5af90b3e4ea428f582e82f254
Reviewed-on: https://pdfium-review.googlesource.com/21571
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'public')
| -rw-r--r-- | public/PRESUBMIT.py | 33 | ||||
| -rw-r--r-- | public/fpdf_edit.h | 4 |
2 files changed, 35 insertions, 2 deletions
diff --git a/public/PRESUBMIT.py b/public/PRESUBMIT.py new file mode 100644 index 0000000000..35bd873fbc --- /dev/null +++ b/public/PRESUBMIT.py @@ -0,0 +1,33 @@ +# Copyright 2017 The PDFium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +"""Presubmit script for pdfium. + +See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts +for more details about the presubmit API built into depot_tools. +""" + +def _CheckPublicHeaders(input_api, output_api): + """Checks that the public headers match the API tests.""" + src_path = input_api.os_path.dirname(input_api.PresubmitLocalPath()) + check_script = input_api.os_path.join( + src_path, 'testing' , 'tools' , 'api_check.py') + try: + input_api.subprocess.check_output(check_script) + return [] + except input_api.subprocess.CalledProcessError as error: + return [output_api.PresubmitError('api_check.py failed:', + long_text=error.output)] + + +def CheckChangeOnUpload(input_api, output_api): + results = [] + results += _CheckPublicHeaders(input_api, output_api) + return results + + +def CheckChangeOnCommit(input_api, output_api): + results = [] + results += _CheckPublicHeaders(input_api, output_api) + return results diff --git a/public/fpdf_edit.h b/public/fpdf_edit.h index f2dad739ca..3bd246b0ad 100644 --- a/public/fpdf_edit.h +++ b/public/fpdf_edit.h @@ -524,8 +524,8 @@ FPDFPath_SetStrokeWidth(FPDF_PAGEOBJECT path, float width); // // Line join can be one of following: FPDF_LINEJOIN_MITER, FPDF_LINEJOIN_ROUND, // FPDF_LINEJOIN_BEVEL -FPDF_EXPORT void FPDF_CALLCONV FPDF_CALLCONV -FPDFPath_SetLineJoin(FPDF_PAGEOBJECT page_object, int line_join); +FPDF_EXPORT void FPDF_CALLCONV FPDFPath_SetLineJoin(FPDF_PAGEOBJECT page_object, + int line_join); // Set the line cap of |page_object|. // |