diff options
| author | Lei Zhang <thestig@chromium.org> | 2018-02-08 14:01:32 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-02-08 14:01:32 +0000 |
| commit | b0fb8cc23c0ae555726f873101961676f96f6f07 (patch) | |
| tree | 6ff26ef212fd3d123483866eb4053f19189a6262 /testing/test_support.h | |
| parent | 6183a6e7693b7aeb9763eaa130b43269b13a02d7 (diff) | |
| download | pdfium-b0fb8cc23c0ae555726f873101961676f96f6f07.tar.xz | |
[v8-platform] Store the platform in a unique_ptr. (Try 2)
We want to change the signature of {CreateDefaultPlatform} in the V8
API to return a unique_ptr instead of a raw pointer to indicate that the
caller owns the platform. With this change we prepare pdfium for this
change.
In this second attempt, keep the old InitializeV8ForPDFium() method
around to complete the Chromium DEPS roll. Once that lands safely,
remove it from PDFium.
This relands commit 608e8dd6 and commit 3355f459, which commit b3a3eaab
reverts.
Change-Id: Icc60b17ca202637d34ae242c0785d939194d0fe6
Reviewed-on: https://pdfium-review.googlesource.com/25950
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'testing/test_support.h')
| -rw-r--r-- | testing/test_support.h | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/testing/test_support.h b/testing/test_support.h index ec4b4aeacb..00d72b35d1 100644 --- a/testing/test_support.h +++ b/testing/test_support.h @@ -91,12 +91,26 @@ class Platform; namespace v8 { class StartupData; } + +// |natives_blob| and |snapshot_blob| are optional out parameters. They should +// either both be valid or both be nullptrs. +std::unique_ptr<v8::Platform> InitializeV8ForPDFiumWithStartupData( + const std::string& exe_path, + const std::string& bin_dir, + v8::StartupData* natives_blob, + v8::StartupData* snapshot_blob); + +// TODO(thestig): Remove this in the near future once it has no callers. bool InitializeV8ForPDFium(const std::string& exe_path, const std::string& bin_dir, v8::StartupData* natives_blob, v8::StartupData* snapshot_blob, v8::Platform** platform); #else // V8_USE_EXTERNAL_STARTUP_DATA +std::unique_ptr<v8::Platform> InitializeV8ForPDFium( + const std::string& exe_path); + +// TODO(thestig): Remove this in the near future once it has no callers. bool InitializeV8ForPDFium(const std::string& exe_path, v8::Platform** platform); #endif // V8_USE_EXTERNAL_STARTUP_DATA |