summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authortsepez <tsepez@chromium.org>2016-08-15 11:40:12 -0700
committerCommit bot <commit-bot@chromium.org>2016-08-15 11:40:12 -0700
commita4941914bb4411dc4e9053cb344e0349db388007 (patch)
tree5b5784812bddf80eb4a79ed2597f016f8b72d8ce /testing
parent2ba53c176df1bc5bb963901e7cc42c6a60af24eb (diff)
downloadpdfium-a4941914bb4411dc4e9053cb344e0349db388007.tar.xz
Move some v8 objects from CJS back into FXJS
Create a new class to hold these, CFXJS_Engine (could have been called Runtime, but there are too many "Runtimes" already). In a subsequent patch, all the FXJS_*() functions that take an isolate as the first argument can become methods on the engine. CJS_ must still manage the isolates; this happens outside the engine. The IJS_Runtime abstraction moves up to fpdfsdk/javascript; it remains to allow for either a real JS library or a stubb one to be linked (for non-js builds). Review-Url: https://codereview.chromium.org/2241483004
Diffstat (limited to 'testing')
-rw-r--r--testing/js_embedder_test.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/testing/js_embedder_test.cpp b/testing/js_embedder_test.cpp
index 5927d89af5..1b21fe04db 100644
--- a/testing/js_embedder_test.cpp
+++ b/testing/js_embedder_test.cpp
@@ -21,12 +21,12 @@ void JSEmbedderTest::SetUp() {
v8::Isolate::Scope isolate_scope(m_pIsolate);
v8::HandleScope handle_scope(m_pIsolate);
FXJS_PerIsolateData::SetUp(m_pIsolate);
- FXJS_InitializeRuntime(m_pIsolate, nullptr, &m_pPersistentContext,
- &m_StaticObjects);
+ FXJS_InitializeEngine(m_pIsolate, nullptr, &m_pPersistentContext,
+ &m_StaticObjects);
}
void JSEmbedderTest::TearDown() {
- FXJS_ReleaseRuntime(m_pIsolate, &m_pPersistentContext, &m_StaticObjects);
+ FXJS_ReleaseEngine(m_pIsolate, &m_pPersistentContext, &m_StaticObjects);
m_pPersistentContext.Reset();
EmbedderTest::TearDown();
m_pIsolate->Dispose();