summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorLei Zhang <thestig@chromium.org>2018-10-18 19:15:47 +0000
committerChromium commit bot <commit-bot@chromium.org>2018-10-18 19:15:47 +0000
commit378ec548964d57311faab4627e570566bd20aaa0 (patch)
tree4b34aed8a671fb573363aab7f571de38e8e62237 /testing
parentd66f39a421233931d4da0832c72aae965ad909ee (diff)
downloadpdfium-378ec548964d57311faab4627e570566bd20aaa0.tar.xz
Remove a few V8 includes from header files.
Change-Id: I087c4e712aa87f99ada4ef515f5b361037a5dae0 Reviewed-on: https://pdfium-review.googlesource.com/c/44257 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'testing')
-rw-r--r--testing/embedder_test.cpp6
-rw-r--r--testing/embedder_test.h8
2 files changed, 7 insertions, 7 deletions
diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 10b944d608..6dd13e2dc4 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -94,6 +94,12 @@ void EmbedderTest::TearDown() {
delete loader_;
}
+#ifdef PDF_ENABLE_V8
+void EmbedderTest::SetExternalIsolate(void* isolate) {
+ external_isolate_ = static_cast<v8::Isolate*>(isolate);
+}
+#endif // PDF_ENABLE_V8
+
bool EmbedderTest::CreateEmptyDocument() {
document_ = FPDF_CreateNewDocument();
if (!document_)
diff --git a/testing/embedder_test.h b/testing/embedder_test.h
index fc9624118d..37c5ca8c27 100644
--- a/testing/embedder_test.h
+++ b/testing/embedder_test.h
@@ -20,10 +20,6 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/test_support.h"
-#ifdef PDF_ENABLE_V8
-#include "v8/include/v8.h"
-#endif // PDF_ENABLE_v8
-
class TestLoader;
// This class is used to load a PDF document, and then run programatic
@@ -75,9 +71,7 @@ class EmbedderTest : public ::testing::Test,
#ifdef PDF_ENABLE_V8
// Call before SetUp to pass shared isolate, otherwise PDFium creates one.
- void SetExternalIsolate(void* isolate) {
- external_isolate_ = static_cast<v8::Isolate*>(isolate);
- }
+ void SetExternalIsolate(void* isolate);
#endif // PDF_ENABLE_V8
void SetDelegate(Delegate* delegate) {