summaryrefslogtreecommitdiff
path: root/testing
diff options
context:
space:
mode:
authorHenrique Nakashima <hnakashima@chromium.org>2017-11-13 20:05:43 +0000
committerChromium commit bot <commit-bot@chromium.org>2017-11-13 20:05:43 +0000
commitf2d490650cef611f92e5d4a112c90647f08f054e (patch)
tree8b54644a046ad4b641bcba8594512e9784f59b2c /testing
parentcee39e6e90c219cc91f2c94a912a06977f4461a0 (diff)
downloadpdfium-f2d490650cef611f92e5d4a112c90647f08f054e.tar.xz
Remove virtual from EmbedderTest methods that are not overridden.chromium/3268
Change-Id: I405e3fcd23fb0fcffa5abdea6cb9a3ab6e62a8f6 Reviewed-on: https://pdfium-review.googlesource.com/18390 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Diffstat (limited to 'testing')
-rw-r--r--testing/embedder_test.h20
1 files changed, 10 insertions, 10 deletions
diff --git a/testing/embedder_test.h b/testing/embedder_test.h
index 7b6b40a818..87c1fad6f1 100644
--- a/testing/embedder_test.h
+++ b/testing/embedder_test.h
@@ -81,7 +81,7 @@ class EmbedderTest : public ::testing::Test,
// Create an empty document, and its form fill environment. Returns true
// on success or false on failure.
- virtual bool CreateEmptyDocument();
+ bool CreateEmptyDocument();
// Open the document specified by |filename|, and create its form fill
// environment, or return false on failure.
@@ -92,27 +92,27 @@ class EmbedderTest : public ::testing::Test,
bool must_linearize = false);
// Perform JavaScript actions that are to run at document open time.
- virtual void DoOpenActions();
+ void DoOpenActions();
// Determine the page numbers present in the document.
- virtual int GetFirstPageNum();
- virtual int GetPageCount();
+ int GetFirstPageNum();
+ int GetPageCount();
// Load a specific page of the open document.
- virtual FPDF_PAGE LoadPage(int page_number);
+ FPDF_PAGE LoadPage(int page_number);
// Convert a loaded page into a bitmap.
- virtual FPDF_BITMAP RenderPage(FPDF_PAGE page);
+ FPDF_BITMAP RenderPage(FPDF_PAGE page);
// Convert a loaded page into a bitmap with page rendering flags specified.
// See public/fpdfview.h for a list of page rendering flags.
- virtual FPDF_BITMAP RenderPageWithFlags(FPDF_PAGE page,
- FPDF_FORMHANDLE handle,
- int flags);
+ FPDF_BITMAP RenderPageWithFlags(FPDF_PAGE page,
+ FPDF_FORMHANDLE handle,
+ int flags);
// Relese the resources obtained from LoadPage(). Further use of |page|
// is prohibited after this call is made.
- virtual void UnloadPage(FPDF_PAGE page);
+ void UnloadPage(FPDF_PAGE page);
protected:
bool OpenDocumentHelper(const char* password,