diff options
| author | dsinclair <dsinclair@chromium.org> | 2016-11-10 09:40:14 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-11-10 09:40:14 -0800 |
| commit | 98329fe75b9c3e5422344a37d787fb22c89c2ca2 (patch) | |
| tree | a1e7f3d35bc97695b074756ab7ef531c17c6262d /xfa/fwl/core/cfwl_combobox.cpp | |
| parent | 50feafc7f367a87b7e4e689421eb7ae1484660d9 (diff) | |
| download | pdfium-98329fe75b9c3e5422344a37d787fb22c89c2ca2.tar.xz | |
Cleanup IFWL_Widget visibility and virtual parameters
This Cl cleans up the IFWL_Widget class including:
* Making members and methods private where possible
* Removing virtual methods that are never overridden
* Removing methods that do nothing
* Removing unchecked FWL_Error return codes
Review-Url: https://codereview.chromium.org/2488953003
Diffstat (limited to 'xfa/fwl/core/cfwl_combobox.cpp')
| -rw-r--r-- | xfa/fwl/core/cfwl_combobox.cpp | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/xfa/fwl/core/cfwl_combobox.cpp b/xfa/fwl/core/cfwl_combobox.cpp index 9b2cf7fe41..825d66382e 100644 --- a/xfa/fwl/core/cfwl_combobox.cpp +++ b/xfa/fwl/core/cfwl_combobox.cpp @@ -91,9 +91,9 @@ FWL_Error CFWL_ComboBox::SetCurSel(int32_t iSel) { : FWL_Error::Indefinite; } -FWL_Error CFWL_ComboBox::SetEditText(const CFX_WideString& wsText) { - return GetWidget() ? ToComboBox(GetWidget())->SetEditText(wsText) - : FWL_Error::Indefinite; +void CFWL_ComboBox::SetEditText(const CFX_WideString& wsText) { + if (GetWidget()) + ToComboBox(GetWidget())->SetEditText(wsText); } int32_t CFWL_ComboBox::GetEditTextLength() const { @@ -160,8 +160,8 @@ void* CFWL_ComboBox::GetItemData(int32_t iIndex) { return pItem ? pItem->m_pData : nullptr; } -FWL_Error CFWL_ComboBox::SetListTheme(IFWL_ThemeProvider* pTheme) { - return ToComboBox(GetWidget())->GetListBoxt()->SetThemeProvider(pTheme); +void CFWL_ComboBox::SetListTheme(IFWL_ThemeProvider* pTheme) { + ToComboBox(GetWidget())->GetListBoxt()->SetThemeProvider(pTheme); } bool CFWL_ComboBox::AfterFocusShowDropList() { @@ -229,12 +229,12 @@ FWL_Error CFWL_ComboBox::GetBBox(CFX_RectF& rect) { : FWL_Error::Indefinite; } -FWL_Error CFWL_ComboBox::EditModifyStylesEx(uint32_t dwStylesExAdded, - uint32_t dwStylesExRemoved) { - return GetWidget() - ? ToComboBox(GetWidget()) - ->EditModifyStylesEx(dwStylesExAdded, dwStylesExRemoved) - : FWL_Error::Indefinite; +void CFWL_ComboBox::EditModifyStylesEx(uint32_t dwStylesExAdded, + uint32_t dwStylesExRemoved) { + if (GetWidget()) { + ToComboBox(GetWidget()) + ->EditModifyStylesEx(dwStylesExAdded, dwStylesExRemoved); + } } FWL_Error CFWL_ComboBox::GetCaption(IFWL_Widget* pWidget, |