diff options
| author | dan sinclair <dsinclair@chromium.org> | 2018-04-17 21:34:18 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-04-17 21:34:18 +0000 |
| commit | 13aa65a71294cac6e4bdaab73ddd6f4b9fcd8676 (patch) | |
| tree | 478874bff3e2831949884adfe750a4924832eb54 /xfa/fxfa/parser/cxfa_document.cpp | |
| parent | 35939f83e45b67de4ccc8c3e70e5e00be40326b6 (diff) | |
| download | pdfium-13aa65a71294cac6e4bdaab73ddd6f4b9fcd8676.tar.xz | |
Add ownership to CFX_XMLNode children
This CL sets the CFX_XML tree ownership. The pointers set into the tree
must be unique_ptrs and the CFX_XMLNode children are set to be either
unique_ptrs or UnownedPtrs.
Change-Id: Ib0db495c81471e40f5b4533503f7bbe5a784fd77
Reviewed-on: https://pdfium-review.googlesource.com/30711
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'xfa/fxfa/parser/cxfa_document.cpp')
| -rw-r--r-- | xfa/fxfa/parser/cxfa_document.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xfa/fxfa/parser/cxfa_document.cpp b/xfa/fxfa/parser/cxfa_document.cpp index 713e15c4fa..c3e73e2f19 100644 --- a/xfa/fxfa/parser/cxfa_document.cpp +++ b/xfa/fxfa/parser/cxfa_document.cpp @@ -7,6 +7,7 @@ #include "xfa/fxfa/parser/cxfa_document.h" #include <set> +#include <utility> #include "core/fxcrt/fx_extension.h" #include "core/fxcrt/fx_fallthrough.h" @@ -1633,7 +1634,7 @@ void CXFA_Document::DoDataMerge() { false); CFX_XMLElement* ref = pDatasetsXMLNode.get(); - m_pRootNode->GetXMLMappingNode()->AppendChild(pDatasetsXMLNode.release()); + m_pRootNode->GetXMLMappingNode()->AppendChild(std::move(pDatasetsXMLNode)); m_pRootNode->InsertChild(pDatasetsRoot, nullptr); pDatasetsRoot->SetXMLMappingNode(ref); } |