summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrad Beckmann <Brad.Beckmann@amd.com>2010-03-22 11:19:17 -0700
committerBrad Beckmann <Brad.Beckmann@amd.com>2010-03-22 11:19:17 -0700
commit66632539b65af333bbf3d00fde9e249f97a8ab8e (patch)
treed66e7970411979004431084382bf57996ac111d6
parent7aba8d7db0c73d723863a90513b1e6511a386000 (diff)
downloadgem5-66632539b65af333bbf3d00fde9e249f97a8ab8e.tar.xz
ruby: improved isReadWrite fix me comment
-rw-r--r--src/mem/ruby/system/RubyPort.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mem/ruby/system/RubyPort.cc b/src/mem/ruby/system/RubyPort.cc
index 314f551d1..480c13ad8 100644
--- a/src/mem/ruby/system/RubyPort.cc
+++ b/src/mem/ruby/system/RubyPort.cc
@@ -230,8 +230,10 @@ RubyPort::M5Port::recvTiming(PacketPtr pkt)
type = RubyRequestType_ST;
} else if (pkt->isReadWrite()) {
//
- // Fix me. Just because the packet is a read/write request does not
- // necessary mean it is a read-modify-write atomic operation.
+ // Fix me. This conditional will never be executed because
+ // isReadWrite() is just an OR of isRead() and isWrite().
+ // Furthermore, just because the packet is a read/write request does
+ // not necessary mean it is a read-modify-write atomic operation.
//
type = RubyRequestType_RMW_Write;
} else {