diff options
| author | Hongil Yoon <ongal@cs.wisc.edu> | 2015-09-15 08:14:06 -0500 |
|---|---|---|
| committer | Hongil Yoon <ongal@cs.wisc.edu> | 2015-09-15 08:14:06 -0500 |
| commit | fb0f9884e27f33c434ef67a5cfd284331a2a89e0 (patch) | |
| tree | a3c1c8df37385eb1c2e7b5ace8631a93bd40b3ff /src/cpu/base_dyn_inst.hh | |
| parent | 6bee1d912482ee57ed79bb557afdad25563e9955 (diff) | |
| download | gem5-fb0f9884e27f33c434ef67a5cfd284331a2a89e0.tar.xz | |
cpu, o3: consider split requests for LSQ checksnoop operations
This patch enables instructions in LSQ to track two physical addresses for
corresponding two split requests. Later, the information is used in
checksnoop() to search for/invalidate the corresponding LD instructions.
The current implementation has kept track of only the physical address that is
referenced by the first split request. Thus, for checksnoop(), the line
accessed by the second request has not been considered, causing potential
correctness issues.
Committed by: Nilay Vaish <nilay@cs.wisc.edu>
Diffstat (limited to 'src/cpu/base_dyn_inst.hh')
| -rw-r--r-- | src/cpu/base_dyn_inst.hh | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/src/cpu/base_dyn_inst.hh b/src/cpu/base_dyn_inst.hh index aae3af495..c2ef253a7 100644 --- a/src/cpu/base_dyn_inst.hh +++ b/src/cpu/base_dyn_inst.hh @@ -215,7 +215,12 @@ class BaseDynInst : public ExecContext, public RefCounted Addr effAddr; /** The effective physical address. */ - Addr physEffAddr; + Addr physEffAddrLow; + + /** The effective physical address + * of the second request for a split request + */ + Addr physEffAddrHigh; /** The memory request flags (from translation). */ unsigned memReqFlags; @@ -1056,7 +1061,15 @@ BaseDynInst<Impl>::finishTranslation(WholeTranslationState *state) instFlags[IsStrictlyOrdered] = state->isStrictlyOrdered(); if (fault == NoFault) { - physEffAddr = state->getPaddr(); + // save Paddr for a single req + physEffAddrLow = state->getPaddr(); + + // case for the request that has been split + if (state->isSplit) { + physEffAddrLow = state->sreqLow->getPaddr(); + physEffAddrHigh = state->sreqHigh->getPaddr(); + } + memReqFlags = state->getFlags(); if (state->mainReq->isCondSwap()) { |